From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A359CA04BA; Sun, 4 Oct 2020 19:00:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E01A31B9CE; Sun, 4 Oct 2020 19:00:12 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by dpdk.org (Postfix) with ESMTP id 762301B96F for ; Sun, 4 Oct 2020 19:00:11 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id g18so2059387pgd.5 for ; Sun, 04 Oct 2020 10:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E5Sg5Sh/qnMnOVDCwk2yJZxn5K3TerOc+eosRmGrHaA=; b=B9dkUoJMc9BqHlR0C6GyNV8EoEXmyPzsuV8I8WkbzS157SXsL+MXQqEryYtKWm8kq3 +3QaraUxawUhOlRh+d4ohql1tIC2FiYAMllYpup1/tU1GWPvGWKwq61gPa3nOiOyNBFV X6u9jxX4wzAl3rAeusKZlRsHwlJGNQbGHfDDksy9ZYH1GkQvo/h8LCjKo4bXbNdwMGzC DuD2wsP3K3nUD5PHxIW2AacLcSLEBet4Kj6lsa2JL/Ug99zwHRDNZtOcv2YyqCE+9x2n 00VpHK4+SfSUQrtxDtdwC11Qf4J1SxhgxxtyCQ2I7Sww49Ivi9MgEhI+GTWrR1eE0h5y ncuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E5Sg5Sh/qnMnOVDCwk2yJZxn5K3TerOc+eosRmGrHaA=; b=mWObzAuCVEtGxq63gzdEFJryt7xpROhoWQAp6QU0f2obdejFFVVek4sZnMSCo5R+Il tWHMcb6az69rkF0WXLxdAEkKHMq+mIkTFleNIZB5Q2rJxG3KjBVB3HWVRJzLsZYaTEKl L5QaZItgY1WKWAIZPkmk5Q0hQOgcUHPQZC52BdzG5f9mrNDUXaoewuBvglsvKQmW+hQb 9U7g51jij2X1V/u7xmIFuDSco+z5p8p+WxtisTkdBH8jJGKn9F3XMD8pEbODDVlpGR4D JWxk/SlLIVQ/YLyBUKj9fNEBN1LL/In+NggNWMI9hjro40BNIQNe4yrOkcbK6bvtcuW5 Q2eg== X-Gm-Message-State: AOAM531sGKxg72p9PoCY5acXhGe3RcRAEFzUcTlj0voJCmbI5K3BIunM 0Jx7hUPLG2YNNLXwbB0Z7zVhZg== X-Google-Smtp-Source: ABdhPJyV8YOjq+zn4RUNXt34k5HR6ueaxZ49dMMg87Vqu8SnIvEmNmhcDuPDV2R6OQfkPosn7oJ05Q== X-Received: by 2002:a63:d65:: with SMTP id 37mr10683806pgn.139.1601830809517; Sun, 04 Oct 2020 10:00:09 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z10sm591814pff.218.2020.10.04.10.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 10:00:09 -0700 (PDT) Date: Sun, 4 Oct 2020 10:00:00 -0700 From: Stephen Hemminger To: Andrey Vesnovaty Cc: dev@dpdk.org, jer@marvell.com, jerinjacobk@gmail.com, thomas@monjalon.net, ferruh.yigit@intel.com, bruce.richardson@intel.com, orika@nvidia.com, viacheslavo@nvidia.com, andrey.vesnovaty@gmail.com, mdr@ashroe.eu, nhorman@tuxdriver.com, ajit.khaparde@broadcom.com, samik.gupta@broadcom.com, Andrey Vesnovaty , Andrew Rybchenko , Ori Kam Message-ID: <20201004100000.3903bda8@hermes.local> In-Reply-To: <20201003220619.19231-2-andreyv@nvidia.com> References: <20201003220619.19231-1-andreyv@nvidia.com> <20201003220619.19231-2-andreyv@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 4 Oct 2020 01:06:10 +0300 Andrey Vesnovaty wrote: > This commit introduces extension of DPDK flow action API enabling > sharing of single rte_flow_action in multiple flows. The API intended for > PMDs where multiple HW offloaded flows can reuse the same HW > essence/object representing flow action and modification of such an > essence/object effects all the rules using it. > > Motivation and example > === > Adding or removing one or more queues to RSS used by multiple flow rules > imposes per rule toll for current DPDK flow API; the scenario requires > for each flow sharing cloned RSS action: > - call `rte_flow_destroy()` > - call `rte_flow_create()` with modified RSS action > > API for sharing action and its in-place update benefits: > - reduce the overhead of multiple RSS flow rules reconfiguration > - optimize resource utilization by sharing action across of multiple > flows > > Change description > === > > Shared action > === > In order to represent flow action shared by multiple flows new action > type RTE_FLOW_ACTION_TYPE_SHARED is introduced (see `enum > rte_flow_action_type`). > Actually the introduced API decouples action from any specific flow and > enables sharing of single action by its handle across multiple flows. > > Shared action create/use/destroy > === > Shared action may be reused by some or none flow rules at any given > moment, i.e. shared action reside outside of the context of any flow. > Shared action represent HW resources/objects used for action offloading > implementation. > API for shared action create (see `rte_flow_shared_action_create()`): > - should allocate HW resources and make related initializations required > for shared action implementation. > - make necessary preparations to maintain shared access to > the action resources, configuration and state. > API for shared action destroy (see `rte_flow_shared_action_destroy()`) > should release HW resources and make related cleanups required for shared > action implementation. > > In order to share some flow action reuse the handle of type > `struct rte_flow_shared_action` returned by > rte_flow_shared_action_create() as a `conf` field of > `struct rte_flow_action` (see "example" section). > > If some shared action not used by any flow rule all resources allocated > by the shared action can be released by rte_flow_shared_action_destroy() > (see "example" section). The shared action handle passed as argument to > destroy API should not be used any further i.e. result of the usage is > undefined. > > Shared action re-configuration > === > Shared action behavior defined by its configuration can be updated via > rte_flow_shared_action_update() (see "example" section). The shared > action update operation modifies HW related resources/objects allocated > on the action creation. The number of operations performed by the update > operation should not be dependent on number of flows sharing the related > action. On return of shared action update API action behavior should be > according to updated configuration for all flows sharing the action. > > Shared action query > === > Provide separate API to query shared action sate (see > rte_flow_shared_action_update()). Taking a counter as an example: query > returns value aggregating all counter increments across all flow rules > sharing the counter. > > PMD support > === > The support of introduced API is pure PMD specific design and > responsibility for each action type (see struct rte_flow_ops). > > testpmd > === > In order to utilize introduced API testpmd cli may implement following > extension > create/update/destroy/query shared action accordingly > > flow shared_action (port) create {action_id (id)} (action) / end > flow shared_action (port) update (id) (action) / end > flow shared_action (port) destroy action_id (id) {action_id (id) [...]} > flow shared_action (port) query (id) > > testpmd example > === > > configure rss to queues 1 & 2 > > > flow shared_action 0 create action_id 100 rss queues 1 2 end / end > > create flow rule utilizing shared action > > > flow create 0 ingress \ > pattern eth dst is 0c:42:a1:15:fd:ac / ipv6 / tcp / end \ > actions shared 100 / end > > add 2 more queues > > > flow shared_action 0 modify 100 rss queues 1 2 3 4 end / end > > example > === > > struct rte_flow_action actions[2]; > struct rte_flow_action action; > /* skipped: initialize action */ > struct rte_flow_shared_action *handle = rte_flow_shared_action_create( > port_id, &action, &error); > actions[0].type = RTE_FLOW_ACTION_TYPE_SHARED; > actions[0].conf = handle; > actions[1].type = RTE_FLOW_ACTION_TYPE_END; > /* skipped: init attr0 & pattern0 args */ > struct rte_flow *flow0 = rte_flow_create(port_id, &attr0, pattern0, > actions, error); > /* create more rules reusing shared action */ > struct rte_flow *flow1 = rte_flow_create(port_id, &attr1, pattern1, > actions, error); > /* skipped: for flows 2 till N */ > struct rte_flow *flowN = rte_flow_create(port_id, &attrN, patternN, > actions, error); > /* update shared action */ > struct rte_flow_action updated_action; > /* > * skipped: initialize updated_action according to desired action > * configuration change > */ > rte_flow_shared_action_update(port_id, handle, &updated_action, error); > /* > * from now on all flows 1 till N will act according to configuration of > * updated_action > */ > /* skipped: destroy all flows 1 till N */ > rte_flow_shared_action_destroy(port_id, handle, error); > > Signed-off-by: Andrey Vesnovaty > Signed-off-by: Andrey Vesnovaty Before this can be accepted, you need to add a test. Ideally part of the test infrastructure, but a a minimum some way to demonstrate usage with testpmd.