From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1722A04B1; Mon, 5 Oct 2020 17:35:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E3B21B673; Mon, 5 Oct 2020 17:35:07 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id C20FA1B669 for ; Mon, 5 Oct 2020 17:35:04 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id nl2so182701pjb.1 for ; Mon, 05 Oct 2020 08:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wOYSihMxVqzQc6W8nswBEaxQXxHzpB/enqjcoXkrE5k=; b=CZlIKIKpvzoi6YHi/CDXoeZMbhlKjkOdbqNr789GkUU+PvT36Ixfmms2TIgpCAVfGD Yrq3fTCp0XVyHmlNp6NzYPieu/jJVf/tUXgu2axTYssZhVDug1xN0Hjbgd6oqvnobuyE s3wFyPrwh1xQs96L7Qp1brolIW52qKHgNsYATSiQxHKuuxm5xpDU4Mjt5vqckvzg9dWo MQeorxsDNb1pNHIcAe3N4u+o23cZbxwMN6n+3/etA4XXMrpll5TtailzJVKODYDOVC3i Qvbvzm7BSsScjCKLAa5xlK/7GNk1aEIDWWUdZOkmx2JU9yM9B94WyjzzbCTwf3QuBAcp HUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wOYSihMxVqzQc6W8nswBEaxQXxHzpB/enqjcoXkrE5k=; b=Whj3JJcfF4qpksilet/OT4xJRzX2mgSXGAeWnZwxIGMzdB2kg8/RtbNelbTUPNve5f b7VWZDE3YCUQyi1Wy6Za1sAt2Y22cj9ntFD6ovzgYawfKrZzVCfn+sHXumWFG2nhfdUz 8D7oTyEPm/v5cpl+QYwe6LBB6QMn6a7qDyM7bMVKnCttF1GOASouBiRX5Ihksj+eXZWa CJOiVd2eUtKHHn36yrihIpXpnpc1D2MZV0rM7h+4FZAt+6SmiVey3Iqf2Sr33DbkcwLs lz+FiHl6bF66EWLEY9smpO8vw/KPwhIgYy5P8N8Ci+ScPjieURLopynl5jO2Kl2fpv9m k2LQ== X-Gm-Message-State: AOAM533/yCiJi2aJRH6xwuUKpsWbamSiCMyBhRx3HPfx2xFW7fAn0lYP dD7MeCNuWHXDUHESZoriQDVvjg== X-Google-Smtp-Source: ABdhPJzdpr8MK2O17AYRzCp2LaydBjpZ/Ck5v1R8PsJcFvyM1c14NLBcJzfUM3T+B5Bh6J4tFcmg8A== X-Received: by 2002:a17:90a:4043:: with SMTP id k3mr390356pjg.141.1601912103899; Mon, 05 Oct 2020 08:35:03 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p12sm19676pgm.29.2020.10.05.08.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 08:35:03 -0700 (PDT) Date: Mon, 5 Oct 2020 08:34:55 -0700 From: Stephen Hemminger To: nipun.gupta@nxp.com Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, rohit.raj@nxp.com Message-ID: <20201005083455.2fdf57f2@hermes.local> In-Reply-To: <20201005071506.28861-1-nipun.gupta@nxp.com> References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201005071506.28861-1-nipun.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 5 Oct 2020 12:45:04 +0530 nipun.gupta@nxp.com wrote: > From: Nipun Gupta > > This change adds a RX offload capability, which once enabled, > hardware will drop the packets in case there of any error in > the packet such as L3 checksum error or L4 checksum. > > Signed-off-by: Nipun Gupta > Signed-off-by: Rohit Raj > --- > These patches are based over series: > https://patchwork.dpdk.org/patch/78630/ > > Changes in v2: > - Add support in DPAA1 driver (patch 2/3) > - Add support and config parameter in testpmd (patch 3/3) > > lib/librte_ethdev/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) Maybe this should be an rte_flow match/action which would then make it more flexible? There is not much of a performance gain for this in real life and if only one driver supports it then I am not convinced this is needed.