From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 13821A04BA;
	Mon,  5 Oct 2020 12:19:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A13581B62B;
	Mon,  5 Oct 2020 12:19:11 +0200 (CEST)
Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net
 [217.70.183.200]) by dpdk.org (Postfix) with ESMTP id 460712BE6
 for <dev@dpdk.org>; Mon,  5 Oct 2020 12:19:10 +0200 (CEST)
X-Originating-IP: 86.254.165.59
Received: from u256.net (lfbn-poi-1-843-59.w86-254.abo.wanadoo.fr
 [86.254.165.59]) (Authenticated sender: grive@u256.net)
 by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0EED720008;
 Mon,  5 Oct 2020 10:19:07 +0000 (UTC)
Date: Mon, 5 Oct 2020 12:19:02 +0200
From: =?utf-8?Q?Ga=C3=ABtan?= Rivet <grive@u256.net>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com,
 Anatoly Burakov <anatoly.burakov@intel.com>
Message-ID: <20201005101844.calrhrazj5j2mwv2@u256.net>
References: <20200913220711.3768597-1-thomas@monjalon.net>
 <20200928231437.414489-1-thomas@monjalon.net>
 <20200928231437.414489-12-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200928231437.414489-12-thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3 11/29] net/failsafe: release port upon
	close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

On 29/09/20 01:14 +0200, Thomas Monjalon wrote:
> The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources
> can be freed by rte_eth_dev_close().
> 
> Freeing of private port resources is moved
> from the ".remove(device)" to the ".dev_close(port)" operation.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Thanks for doing this. LGTM:

Acked-by: Gaetan Rivet <grive@u256.net>

-- 
Gaëtan