From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 945D1A04B1; Mon, 5 Oct 2020 17:33:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7A4B1B673; Mon, 5 Oct 2020 17:33:39 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id DD2A81B669 for ; Mon, 5 Oct 2020 17:33:38 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id p15so4614413wmi.4 for ; Mon, 05 Oct 2020 08:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bOzp9VXTxN29Wd40uPuT0qxFWj7O68nxvpb8XSqtB6M=; b=Xfkn/zd7luQMjkezBR89X3qyJdXhy0QzLxcaowiTT3PSDUkg/dudxUFr5J49Pib/C5 ffW7EkQqoXjUcU5gN8ZXTakIvaDoUvZOrEAQ97p7hGtu5OacBx5BpcVl5a7hQhvZOH+B yCyqu5gUU0P3mRWqXopwbA8pAZpQohw1EQkJOAERlGkkk14HVOuBtvS6esOtLkDCRZHk jV9pA5F6kyihVImCFsDRYYhiJI1P4hKOILZF5iHXniiCnpYv95N70sWBlsZt/y4mi1qI RvOixas5jop/krBrSGha4A2j8PFBxtF8C+zyG9RxtOw7DVef4s11FDDe3yZ24nP/0oiK eLXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bOzp9VXTxN29Wd40uPuT0qxFWj7O68nxvpb8XSqtB6M=; b=ulveG3lSydHtha+vVwPwj/tsIR1VANLCMUzOTcjUPlGrteyftZmvR0vtjBTroMFRgn x0iCtVjvjd3TKVEPyWQQF0cZifnrepZNq8jWxkJLejO91pFeZdG7tKSAtAG+wqdqVFp0 3i5MZaFSnIN2xbNzET34c7Z28EqiF45CkvdbnBCGgiqJ1CHm7RVkR5Y2DIWYEyik+Aq5 gFHgkFPE7dHiEyK1h3X9yAYopUrWthtYxL0U6MjoU3Ig2HLKpYMOIxsClW3UEMvIkcC/ pL2Lfh2n5m16lwBur5Qs1D1ajF8k2l9PpIYHDdxj0JlhHFBe0dQGavml3wEuOo9G+co7 ywdw== X-Gm-Message-State: AOAM531Oeyep5Y3HMIXBANFaFUz4hmDaWLZGB8mM3/JH/JEDnFBToGtA wrcgyPytv1x7eoLoP+XsyL+4Jw== X-Google-Smtp-Source: ABdhPJzqGeUAuel3wjPCNBgUZJYMuGN1iBwo94K40lx0V5jI3VrR32mw9ygPawyLIWccUcynqzI9IQ== X-Received: by 2002:a1c:f214:: with SMTP id s20mr204261wmc.84.1601912017514; Mon, 05 Oct 2020 08:33:37 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id m18sm81579wmg.32.2020.10.05.08.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 08:33:36 -0700 (PDT) Date: Mon, 5 Oct 2020 17:33:35 +0200 From: Olivier Matz To: Dmitry Kozlyuk Cc: dev@dpdk.org, "Kinsella, Ray" , Khoa To , Stephen Hemminger , Ferruh Yigit Message-ID: <20201005153335.GD21395@platinum> References: <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200928215052.23627-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928215052.23627-1-dmitry.kozliuk@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v3 0/7] cmdline: support Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, On Tue, Sep 29, 2020 at 12:50:45AM +0300, Dmitry Kozlyuk wrote: > This patchset enables librte_cmdline on Windows. To do that, it creates > a number of wrappers for OS-dependent terminal handling and I/O. > Considered alternative was to revive [1] and use libedit (Unix-only) > for terminal handling. However, testing revealed that WinEditLine [2] > is not a drop-in replacement for libedit, so this solution wouldn't be > universal. > > [1]: http://patchwork.dpdk.org/patch/38561 > [2]: http://mingweditline.sourceforge.net > > v3: > * Add #ifdef workaround to keep API/ABI for Unices (Olivier). > * Fix missing cmdline_free() in test (Olivier). > * Rebase on ToT (Khoa). > > Dmitry Kozlyuk (7): > cmdline: make implementation logically opaque > cmdline: add internal wrappers for terminal handling > cmdline: add internal wrappers for character input > cmdline: add internal wrapper for vdprintf > eal/windows: improve compatibility networking headers > cmdline: support Windows > examples/cmdline: build on Windows > > app/test-cmdline/commands.c | 8 +- > app/test/test_cmdline_lib.c | 44 ++--- > config/meson.build | 2 + > doc/guides/rel_notes/deprecation.rst | 4 + > examples/cmdline/commands.c | 1 - > examples/cmdline/main.c | 1 - > examples/meson.build | 6 +- > lib/librte_cmdline/cmdline.c | 30 +-- > lib/librte_cmdline/cmdline.h | 18 +- > lib/librte_cmdline/cmdline_os_unix.c | 53 +++++ > lib/librte_cmdline/cmdline_os_windows.c | 207 ++++++++++++++++++++ > lib/librte_cmdline/cmdline_parse.c | 5 +- > lib/librte_cmdline/cmdline_private.h | 53 +++++ > lib/librte_cmdline/cmdline_socket.c | 25 +-- > lib/librte_cmdline/cmdline_vt100.c | 1 - > lib/librte_cmdline/cmdline_vt100.h | 4 + > lib/librte_cmdline/meson.build | 6 + > lib/librte_cmdline/rte_cmdline_version.map | 8 + > lib/librte_eal/windows/include/arpa/inet.h | 30 +++ > lib/librte_eal/windows/include/netinet/in.h | 12 ++ > lib/librte_eal/windows/include/sys/socket.h | 24 +++ > lib/meson.build | 1 + > 22 files changed, 475 insertions(+), 68 deletions(-) > create mode 100644 lib/librte_cmdline/cmdline_os_unix.c > create mode 100644 lib/librte_cmdline/cmdline_os_windows.c > create mode 100644 lib/librte_cmdline/cmdline_private.h > create mode 100644 lib/librte_eal/windows/include/arpa/inet.h > create mode 100644 lib/librte_eal/windows/include/sys/socket.h For series: Acked-by: Olivier Matz Thanks!