From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6630AA04B1; Mon, 5 Oct 2020 18:27:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FB2A1B868; Mon, 5 Oct 2020 18:27:20 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 81BD71B81B for ; Mon, 5 Oct 2020 18:27:18 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id u3so71012pjr.3 for ; Mon, 05 Oct 2020 09:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zCcJDKmoJb7h1J+agOYxMBimwpth1uNf7EnHK2qnH28=; b=ALNDtoPQw5M60IadK2LFiVWQs6EACUQNd0nHPo2HD6f5oHT/NL9EPv8eIbneszPoR6 SB01zc9zRKvxU+JCEuy68dxsXrFx8TCeQsLq5wTXTcPz5uity9CSKoo0eU5H983nYYPc xgRLSlBYSdUW+hM6diAH3v6M27rezg80Qoj2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zCcJDKmoJb7h1J+agOYxMBimwpth1uNf7EnHK2qnH28=; b=HIBWwEQl7GjfoiVGupIEh9yuoW0mPyarVbTaDVPb7YQQ8W7Tye3bHl05PfnhKiX/1c pVAJP5i0UQoX94x0IAvopICe33NTcBg0EYYGn2DyuYdeD1MdoVy0x/wg3LiXPQO7KfEF 5To/Al6hbZTnNUPgVgtdYs0friF2GExSt/nnJfTEkyVtZHh4OUBZWxUCjGwfQxjCHfsC wxkJKC2VlqPaCtGqKTtg9h3CdEvBZ6Xuy+I7J0l1y2ImH/pxY930WEVpqQvfkiRLDMn9 sS5vKTg0/hp7JPkuliqF9r3B2et39uWuVjBFx9L78aubXhn2e7wvZqhhMd+i9QmQwhj8 2jbw== X-Gm-Message-State: AOAM531D6qSHL8wK1jibQVUHW35Ui0laJUR/pdfA36jGDdGuZoSjp4N7 IoLaUA2LWQGQKzLGk2lL8bBhq6SNlemNsvpUTPTjEREw7gCJB3oJxYGk8V+Xb2c/WTPGjgNslaw 6d3gVNQJplYC8sn9d+NGUPveFTGMNdkgGg+CehZ24Q5RZ2Xigz1WyI04Lepfi X-Google-Smtp-Source: ABdhPJwAvMhiZeyxi5wBt1gmIl0lOVZawwD9dqG/6aIFtjXiA3rdmTqnC0G7suEKScqpiea9+M349A== X-Received: by 2002:a17:90a:d356:: with SMTP id i22mr213783pjx.90.1601915236068; Mon, 05 Oct 2020 09:27:16 -0700 (PDT) Received: from rahul_yocto_ubuntu18.ibn.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d129sm378061pfc.161.2020.10.05.09.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 09:27:15 -0700 (PDT) From: Vikas Gupta To: dev@dpdk.org, akhil.goyal@nxp.com Cc: vikram.prakash@broadcom.com, Vikas Gupta , Raveendra Padasalagi Date: Mon, 5 Oct 2020 21:56:52 +0530 Message-Id: <20201005162658.12416-3-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201005162658.12416-1-vikas.gupta@broadcom.com> References: <20200813172344.3228-1-vikas.gupta@broadcom.com> <20201005162658.12416-1-vikas.gupta@broadcom.com> Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] [PATCH v3 2/8] crypto/bcmfs: add vfio support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add VFIO support for BCMFS PMD. The BCMFS PMD functionality is dependent on the VFIO_PRESENT flag, which gets enabled in the rte_vfio.h. If this flag is not enabled in the compiling platform driver will silently return with error, when executed. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- drivers/crypto/bcmfs/bcmfs_device.c | 5 ++ drivers/crypto/bcmfs/bcmfs_device.h | 6 ++ drivers/crypto/bcmfs/bcmfs_vfio.c | 107 ++++++++++++++++++++++++++++ drivers/crypto/bcmfs/bcmfs_vfio.h | 17 +++++ drivers/crypto/bcmfs/meson.build | 3 +- 5 files changed, 137 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/bcmfs/bcmfs_vfio.c create mode 100644 drivers/crypto/bcmfs/bcmfs_vfio.h diff --git a/drivers/crypto/bcmfs/bcmfs_device.c b/drivers/crypto/bcmfs/bcmfs_device.c index c9865ee6a5..1ea6c3b13e 100644 --- a/drivers/crypto/bcmfs/bcmfs_device.c +++ b/drivers/crypto/bcmfs/bcmfs_device.c @@ -12,6 +12,7 @@ #include "bcmfs_device.h" #include "bcmfs_logs.h" +#include "bcmfs_vfio.h" struct bcmfs_device_attr { const char name[BCMFS_MAX_PATH_LEN]; @@ -72,6 +73,10 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev, fsdev->vdev = vdev; + /* attach to VFIO */ + if (bcmfs_attach_vfio(fsdev)) + goto cleanup; + TAILQ_INSERT_TAIL(&fsdev_list, fsdev, next); return fsdev; diff --git a/drivers/crypto/bcmfs/bcmfs_device.h b/drivers/crypto/bcmfs/bcmfs_device.h index cc64a8df2c..c41cc00318 100644 --- a/drivers/crypto/bcmfs/bcmfs_device.h +++ b/drivers/crypto/bcmfs/bcmfs_device.h @@ -35,6 +35,12 @@ struct bcmfs_device { char name[BCMFS_DEV_NAME_LEN]; /* Parent vdev */ struct rte_vdev_device *vdev; + /* vfio handle */ + int vfio_dev_fd; + /* mapped address */ + uint8_t *mmap_addr; + /* mapped size */ + uint32_t mmap_size; }; #endif /* _BCMFS_DEV_H_ */ diff --git a/drivers/crypto/bcmfs/bcmfs_vfio.c b/drivers/crypto/bcmfs/bcmfs_vfio.c new file mode 100644 index 0000000000..dc2def580f --- /dev/null +++ b/drivers/crypto/bcmfs/bcmfs_vfio.c @@ -0,0 +1,107 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(C) 2020 Broadcom. + * All rights reserved. + */ + +#include +#include +#include + +#include + +#include "bcmfs_device.h" +#include "bcmfs_logs.h" +#include "bcmfs_vfio.h" + +#ifdef VFIO_PRESENT +static int +vfio_map_dev_obj(const char *path, const char *dev_obj, + uint32_t *size, void **addr, int *dev_fd) +{ + int32_t ret; + struct vfio_group_status status = { .argsz = sizeof(status) }; + + struct vfio_device_info d_info = { .argsz = sizeof(d_info) }; + struct vfio_region_info reg_info = { .argsz = sizeof(reg_info) }; + + ret = rte_vfio_setup_device(path, dev_obj, dev_fd, &d_info); + if (ret) { + BCMFS_LOG(ERR, "VFIO Setting for device failed"); + return ret; + } + + /* getting device region info*/ + ret = ioctl(*dev_fd, VFIO_DEVICE_GET_REGION_INFO, ®_info); + if (ret < 0) { + BCMFS_LOG(ERR, "Error in VFIO getting REGION_INFO"); + goto map_failed; + } + + *addr = mmap(NULL, reg_info.size, + PROT_WRITE | PROT_READ, MAP_SHARED, + *dev_fd, reg_info.offset); + if (*addr == MAP_FAILED) { + BCMFS_LOG(ERR, "Error mapping region (errno = %d)", errno); + ret = errno; + goto map_failed; + } + *size = reg_info.size; + + return 0; + +map_failed: + rte_vfio_release_device(path, dev_obj, *dev_fd); + + return ret; +} + +int +bcmfs_attach_vfio(struct bcmfs_device *dev) +{ + int ret; + int vfio_dev_fd; + void *v_addr = NULL; + uint32_t size = 0; + + ret = vfio_map_dev_obj(dev->dirname, dev->name, + &size, &v_addr, &vfio_dev_fd); + if (ret) + return -1; + + dev->mmap_size = size; + dev->mmap_addr = v_addr; + dev->vfio_dev_fd = vfio_dev_fd; + + return 0; +} + +void +bcmfs_release_vfio(struct bcmfs_device *dev) +{ + int ret; + + if (dev == NULL) + return; + + /* unmap the addr */ + munmap(dev->mmap_addr, dev->mmap_size); + /* release the device */ + ret = rte_vfio_release_device(dev->dirname, dev->name, + dev->vfio_dev_fd); + if (ret < 0) { + BCMFS_LOG(ERR, "cannot release device"); + return; + } +} +#else +int +bcmfs_attach_vfio(struct bcmfs_device *dev __rte_unused) +{ + return -1; +} + +void +bcmfs_release_vfio(struct bcmfs_device *dev __rte_unused) +{ +} +#endif diff --git a/drivers/crypto/bcmfs/bcmfs_vfio.h b/drivers/crypto/bcmfs/bcmfs_vfio.h new file mode 100644 index 0000000000..d0fdf6483f --- /dev/null +++ b/drivers/crypto/bcmfs/bcmfs_vfio.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2020 Broadcom + * All rights reserved. + */ + +#ifndef _BCMFS_VFIO_H_ +#define _BCMFS_VFIO_H_ + +/* Attach the bcmfs device to vfio */ +int +bcmfs_attach_vfio(struct bcmfs_device *dev); + +/* Release the bcmfs device from vfio */ +void +bcmfs_release_vfio(struct bcmfs_device *dev); + +#endif /* _BCMFS_VFIO_H_ */ diff --git a/drivers/crypto/bcmfs/meson.build b/drivers/crypto/bcmfs/meson.build index a4bdd8ee5d..fd39eba20e 100644 --- a/drivers/crypto/bcmfs/meson.build +++ b/drivers/crypto/bcmfs/meson.build @@ -6,5 +6,6 @@ deps += ['eal', 'bus_vdev'] sources = files( 'bcmfs_logs.c', - 'bcmfs_device.c' + 'bcmfs_device.c', + 'bcmfs_vfio.c' ) -- 2.17.1