From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4D09A04BB; Tue, 6 Oct 2020 11:42:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AE071E35; Tue, 6 Oct 2020 11:42:28 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BBF391C01 for ; Tue, 6 Oct 2020 11:42:26 +0200 (CEST) IronPort-SDR: 8X6oC9aDQblxhk3fOe3+70rCu3W5DsMCpnHN3sD1la9EdTFwURl3O7dOzvodrqMaKnFVxb1q5x zao045jwms6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="181873818" X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="181873818" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 02:42:24 -0700 IronPort-SDR: l6GIv7Rl3a+3ChLepflapp8N+oXif65MmUZSnfEOxhy9dYDV6SzzJJ6ilL5B1SDfpDEC8yCfMi JdmlZ/vaYLiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="517129050" Received: from silpixa00400352.ir.intel.com ([10.237.213.132]) by fmsmga006.fm.intel.com with ESMTP; 06 Oct 2020 02:42:23 -0700 From: David Coyle To: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com Cc: dev@dpdk.org, akhil.goyal@nxp.com, David Coyle Date: Tue, 6 Oct 2020 10:42:15 +0100 Message-Id: <20201006094215.49882-1-david.coyle@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object. This patch fixes this issue by now clearing the private session object. Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") Signed-off-by: David Coyle --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c index 2362f0c3c..b11d7f12b 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c @@ -911,7 +911,7 @@ aesni_mb_pmd_sec_sess_destroy(void *dev __rte_unused, if (sess_priv) { struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv); - memset(sess, 0, sizeof(struct aesni_mb_session)); + memset(sess_priv, 0, sizeof(struct aesni_mb_session)); set_sec_session_private_data(sess, NULL); rte_mempool_put(sess_mp, sess_priv); } -- 2.17.1