From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 208DAA04C0; Tue, 6 Oct 2020 22:38:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 087031B28D; Tue, 6 Oct 2020 22:38:07 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E6EA52C16 for ; Tue, 6 Oct 2020 22:38:01 +0200 (CEST) IronPort-SDR: ccGuCAtxnbYgv3MGehA8QzCnS4r5ksIUbp2qhgc/jRM4ZAx8mTJx0EnouS/U8XpY9xdwoMWoux O5LITLDm3kbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="151607393" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="151607393" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 13:38:00 -0700 IronPort-SDR: ngR4bvdyLU49o6bEd5DOPfvbLyBfX69+U7E6+TAQ8uyrfGh8fH47Va0+Mv05pbY22xftlAIkNE pOicv2ksi3HQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="460985800" Received: from silpixa00400573.ir.intel.com (HELO silpixa00400573.ger.corp.intel.com) ([10.237.223.107]) by orsmga004.jf.intel.com with ESMTP; 06 Oct 2020 13:37:59 -0700 From: Cristian Dumitrescu To: dev@dpdk.org Date: Tue, 6 Oct 2020 21:37:52 +0100 Message-Id: <20201006203755.90779-4-cristian.dumitrescu@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201006203755.90779-1-cristian.dumitrescu@intel.com> References: <20201006203755.90779-1-cristian.dumitrescu@intel.com> Subject: [dpdk-dev] [PATCH 4/7] pipeline: fix memory free issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 3ca60ceed7 ("pipeline: add SWX pipeline specification file") Coverity issues: 362796, 362804, 362819, 362836, 362858, 362865, 362869 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline_spec.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_pipeline/rte_swx_pipeline_spec.c b/lib/librte_pipeline/rte_swx_pipeline_spec.c index 06e1ab438..a4bc8226a 100644 --- a/lib/librte_pipeline/rte_swx_pipeline_spec.c +++ b/lib/librte_pipeline/rte_swx_pipeline_spec.c @@ -35,9 +35,17 @@ struct extobj_spec { static void extobj_spec_free(struct extobj_spec *s) { + if (!s) + return; + free(s->name); + s->name = NULL; + free(s->extern_type_name); + s->extern_type_name = NULL; + free(s->pragma); + s->pragma = NULL; } static int @@ -246,8 +254,14 @@ struct header_spec { static void header_spec_free(struct header_spec *s) { + if (!s) + return; + free(s->name); + s->name = NULL; + free(s->struct_type_name); + s->struct_type_name = NULL; } static int @@ -297,7 +311,11 @@ struct metadata_spec { static void metadata_spec_free(struct metadata_spec *s) { + if (!s) + return; + free(s->struct_type_name); + s->struct_type_name = NULL; } static int -- 2.17.1