From: Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ciara Loftus <ciara.loftus@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: use snprintf instead of strncpy
Date: Wed, 7 Oct 2020 11:51:31 +0200 [thread overview]
Message-ID: <20201007095131.GQ21395@platinum> (raw)
In-Reply-To: <f5b8f112-8d17-6fb5-9703-29ffc0d5357e@intel.com>
On Wed, Oct 07, 2020 at 10:40:32AM +0100, Ferruh Yigit wrote:
> On 10/7/2020 10:01 AM, Ciara Loftus wrote:
> > strncpy may leave the destination buffer not NULL terminated so use
> > snprintf instead.
>
> What do you think using 'strlcpy'?
Or even better, rte_strscpy()
https://git.dpdk.org/dpdk/commit/?id=b0236c7cf761
>
> >
> > Coverity issue: 362975
> > Fixes: 339b88c6a91f ("net/af_xdp: support multi-queue")
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> > ---
> > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
> > index eaf2c9c873..52495cb8fb 100644
> > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> > @@ -1362,7 +1362,7 @@ xdp_get_channels_info(const char *if_name, int *max_queues,
> > channels.cmd = ETHTOOL_GCHANNELS;
> > ifr.ifr_data = (void *)&channels;
> > - strncpy(ifr.ifr_name, if_name, IFNAMSIZ);
> > + snprintf(ifr.ifr_name, IFNAMSIZ, "%s", if_name);
> > ret = ioctl(fd, SIOCETHTOOL, &ifr);
> > if (ret) {
> > if (errno == EOPNOTSUPP) {
> >
>
next prev parent reply other threads:[~2020-10-07 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 9:01 Ciara Loftus
2020-10-07 9:40 ` Ferruh Yigit
2020-10-07 9:51 ` Olivier Matz [this message]
2020-10-07 10:26 ` Bruce Richardson
2020-10-07 10:28 ` Bruce Richardson
2020-10-07 11:45 ` Ferruh Yigit
2020-10-09 10:36 ` Gaëtan Rivet
2020-10-09 10:49 ` Bruce Richardson
2020-10-09 10:59 ` Ferruh Yigit
2020-10-09 16:37 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007095131.GQ21395@platinum \
--to=olivier.matz@6wind.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).