From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6C0ECA04BA;
Wed, 7 Oct 2020 18:36:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id DD5961BCB4;
Wed, 7 Oct 2020 18:34:51 +0200 (CEST)
Received: from relay.smtp-ext.broadcom.com (unknown [192.19.221.30])
by dpdk.org (Postfix) with ESMTP id CED881B868
for <dev@dpdk.org>; Wed, 7 Oct 2020 18:34:44 +0200 (CEST)
Received: from dhcp-10-123-153-22.dhcp.broadcom.net
(bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])
by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 0977D2E5F7
for <dev@dpdk.org>; Wed, 7 Oct 2020 09:34:41 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 0977D2E5F7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;
s=dkimrelay; t=1602088482;
bh=4h7y9vgvpRyCpFrH3eK08bfUkQ0bVYzlp5KyWQsoWg8=;
h=From:To:Subject:Date:In-Reply-To:References:From;
b=umE1wCrgd6FSYYSk9v43pFou5ZybjMBo9CHAo5p26Tq9Exi/MdQuFSf0MS4G/afEs
z/bcFmqpG9QzzJtD40M5K1ovQXLiGCg9aYS+ODzM9dI9c5jR1p1ksCpXH325ahaj0C
8juIsDvPt2EniOdC2ifRfFIyv0FdKMGduKLcmwJI=
From: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
To: dev@dpdk.org
Date: Wed, 7 Oct 2020 22:19:13 +0530
Message-Id: <20201007164915.14375-2-kalesh-anakkur.purayil@broadcom.com>
X-Mailer: git-send-email 2.10.1
In-Reply-To: <20201007164915.14375-1-kalesh-anakkur.purayil@broadcom.com>
References: <20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com>
<20201007164915.14375-1-kalesh-anakkur.purayil@broadcom.com>
Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: support device reset and recovery
events
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Adding support for device reset and recovery events in the
rte_eth_event framework. FW error and FW reset conditions would be
managed internally by PMD without needing application intervention.
In such cases, PMD would need reset/recovery events to notify application
that PMD is undergoing a reset.
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
doc/guides/prog_guide/poll_mode_drv.rst | 18 ++++++++++++++++++
lib/librte_ethdev/rte_ethdev.h | 17 +++++++++++++++++
2 files changed, 35 insertions(+)
diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst
index 86e0a14..c03f0ef 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -615,3 +615,21 @@ by application.
The PMD itself should not call rte_eth_dev_reset(). The PMD can trigger
the application to handle reset event. It is duty of application to
handle all synchronization before it calls rte_eth_dev_reset().
+
+Error recovery support
+~~~~~~~~~~~~~~~~~~~~~~
+
+When the PMD detects a FW reset or error condition, it will try to recover
+from the error without needing the application intervention. In such cases,
+PMD would need events to notify the application that it is undergoing
+an error recovery.
+
+The PMD will trigger RTE_ETH_EVENT_ERR_RECOVERING event to notify the
+application that PMD detected a FW reset or FW error condition. PMD will
+try to recover from the error by itself. Data path will be halted and
+control path operations would fail during the recovery period.
+
+The PMD will trigger RTE_ETH_EVENT_RECOVERED event to notify the application
+that the it has recovered from the error condition. Control path and data path
+are up now. Since the device undergone a reset, flow rules offloaded prior to
+the reset will be lost and the application has to recreate the rules again.
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 9759f13..9b4b015 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -3207,6 +3207,23 @@ enum rte_eth_event_type {
RTE_ETH_EVENT_DESTROY, /**< port is released */
RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */
RTE_ETH_EVENT_FLOW_AGED,/**< New aged-out flows is detected */
+ RTE_ETH_EVENT_ERR_RECOVERING,
+ /**< port recovering from an error
+ *
+ * PMD detected a FW reset or error condition.
+ * PMD will try to recover from the error.
+ * Data path will be halted and Control path operations
+ * would fail at this time.
+ */
+ RTE_ETH_EVENT_RECOVERED,
+ /**< port recovered from an error
+ *
+ * PMD has recovered from the error condition.
+ * Control path and Data path are up now.
+ * Since the device undergone a reset, flow rules
+ * offloaded prior to the reset will be lost and
+ * the application has to recreate the rules again.
+ */
RTE_ETH_EVENT_MAX /**< max value of this enum */
};
--
2.10.1