From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6671A04BC; Thu, 8 Oct 2020 11:02:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B251E1BAB9; Thu, 8 Oct 2020 11:02:53 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2CD461BA6F for ; Thu, 8 Oct 2020 11:02:51 +0200 (CEST) IronPort-SDR: 7txtcCWBD5+qTPvXe6NkgmiRYBhQumACTiwMcdURAXENvRqNfJeZvYvFR6W+N7F9SBxcIWi4Ro x4nrFxZbLBJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="229491323" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="229491323" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 02:02:49 -0700 IronPort-SDR: trL696pN9oupTVmcOFEbY4X1v+cSWk05v8XCkcqCQGPnCQKoaNmmkPSlNAZOMHzCxYgfBtHLrg qC54SwWO7V1g== X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="461746626" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.226.107]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Oct 2020 02:02:46 -0700 Date: Thu, 8 Oct 2020 10:02:43 +0100 From: Bruce Richardson To: David Marchand Cc: Omkar Maslekar , dev , "Ananyev, Konstantin" , Ciara Loftus , David Christensen , Jerin Jacob Kollanukkaran , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Jan Viktorin , Thomas Monjalon Message-ID: <20201008090243.GA1106@bricha3-MOBL.ger.corp.intel.com> References: <1599700614-22809-1-git-send-email-omkar.maslekar@intel.com> <1601512112-12577-1-git-send-email-omkar.maslekar@intel.com> <1601512112-12577-2-git-send-email-omkar.maslekar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v5] eal: add cache-line demote support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 08, 2020 at 09:09:52AM +0200, David Marchand wrote: > On Thu, Oct 1, 2020 at 2:30 AM Omkar Maslekar wrote: > > > > rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) > > enables software to hint to hardware that line is likely to be shared. > > Useful in core-to-core communications where cache-line is likely to be > > shared. ARM and PPC implementation is provided with NOP and can be added > > if any equivalent instructions could be used for implementation on those > > architectures. > > > > Signed-off-by: Omkar Maslekar > > Acked-by: Bruce Richardson > > I find this "rte_cldemote" name too close to the Intel instruction, > but I can see no complaint from other arch maintainers, so I guess > everyone is happy with it. It is very close, alright - though the name too does fairly well convey the likely actual done by the instruction.. Is there a suggestion for a better, more generic name. > In any case, this is a new API, so it should be marked experimental. > Agreed. > As for unit tests, not sure there is much to do, maybe rename > test_prefetch.c and call this new API too, wdyt? > I'm not sure how much value this would provide, but it can be done.