From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20E94A04BC;
	Fri,  9 Oct 2020 04:13:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B9B081BDDF;
	Fri,  9 Oct 2020 04:12:57 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 315721BDDE
 for <dev@dpdk.org>; Fri,  9 Oct 2020 04:12:56 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 6C7AB20B4905; Thu,  8 Oct 2020 19:12:54 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6C7AB20B4905
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1602209574;
 bh=ktp+Z/SrIQiaUIJdHgx3kP5SLL0h/FRCrUu9IgzTVlM=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Zbb5ybZByzhm674zKTxZwZWLu8AgKZT1w9AnbgZNZEZtlKmGQl33lqfLzNV4L06/J
 /TSw6yJRzkO7rqXS0xKHHPEzZoRTZatJKBmSnrDuKucc6cYqme9enNg+6b1V0a20sd
 yhfCE7V9F4itb3cfWPKPOcMP+QS0IkpoU/ShXbLQ=
Date: Thu, 8 Oct 2020 19:12:54 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
 John.Alexander@datapath.co.uk, dmitry.kozliuk@gmail.com,
 Narcisa.Vasile@microsoft.com, talshn@nvidia.com, khot@microsoft.com
Message-ID: <20201009021254.GA13258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20201006215730.1584-1-pallavi.kadam@intel.com>
 <20201008185645.12248-1-pallavi.kadam@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201008185645.12248-1-pallavi.kadam@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v7] bus/pci: netuio interface for windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 08, 2020 at 11:56:45AM -0700, Pallavi Kadam wrote:
> This patch adds implementations to probe PCI devices bound to netuio
> with the help of "netuio" class device changes.
> Now Windows will support both "netuio" and "net" device class and
> can set kernel driver type based on the device class selection.
> 
> Note: Few definitions and structures have been copied from
> netuio_interface.h file from
> ("[v5] windows/netuio: add Windows NetUIO kernel driver") series
> and this will be fixed once the exact path for netuio source code is known.
> 
> v7 changes:
> 	Removed device property key from pci_netuio.c as Numa detection
> 	is done only in pci.c file
> v6 changes:
> 	- Split up the get_netuio_device_info() function into smaller
> 	  functions
> 	- Moved get numa node id code to get_device_resource_info() in
> 	  order to work on both RTE_PCI_KDRV_NONE and RTE_PCI_KDRV_NIC_UIO
> v5 changes:
> 	Changed when netuio driver handle is closed
> v4 changes:
> 	Removed 'reserved' member as it is not used
> v3 changes:
> 	Removed the casts
> v2 changes:
> 	- Moved all netuio specific definitions and functions to
> 	  pci_netuio.c and pci_netuio.h files
> 	- Added a single function call to scan all the devices
> 
> Signed-off-by: John Alexander <John.Alexander@datapath.co.uk>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  drivers/bus/pci/meson.build          |   3 +-
>  drivers/bus/pci/windows/pci.c        |  73 +++++++----
>  drivers/bus/pci/windows/pci_netuio.c | 182 +++++++++++++++++++++++++++
>  drivers/bus/pci/windows/pci_netuio.h |  59 +++++++++
>  4 files changed, 289 insertions(+), 28 deletions(-)
>  create mode 100644 drivers/bus/pci/windows/pci_netuio.c
>  create mode 100644 drivers/bus/pci/windows/pci_netuio.h
> 

Reviewed-by: Narcisa Vasile <navasile@linux.microsoft.com>
Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>