From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 316F6A04B1; Sat, 10 Oct 2020 17:24:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76F881D8EF; Sat, 10 Oct 2020 17:24:24 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id AE6A71D723 for ; Sat, 10 Oct 2020 17:24:23 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id p11so6038724pld.5 for ; Sat, 10 Oct 2020 08:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s4nocczOpwtJGCw9kB1pzl1xpWJn95chnkNAkVpEPB8=; b=E1UyOcHoAHefjKpcuHcKO6lqYvTZHCCUJ6KYcpRacsnDzWN2g1PkUSw4ldL1wI3EZg tgCBOeLAEcFRx+5hBMsnq8j/IFVFt3YCRnLPr2+z7ovBKMnR9suW0Smac3nwZ98IKNSk 6c6b2kEEFB6TABnL78eTtpwxSoOFBov3GTCT93AcHt9zqZN8mN1XSRkNaONjHG7EWaQ2 kjClAXiVo/XanOhiutbDFoFNp1OmelfgT38okpbYDz1oan+KQph2vS4MaC8ulFGg7/1t oUwAUxL6MWcPby9mA+dCL3JgBypJWMm+h2ouu/vxH5KUyZUQ4e+4QAXrYJlInyrDJeuM PgKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s4nocczOpwtJGCw9kB1pzl1xpWJn95chnkNAkVpEPB8=; b=g756JtkqL4eyjeo6JpRJbnvFInNsAnVrQ+Fgnrtf+H1jx2M++1d1Z1N6cytuxcJgUp J3aFlhpp1k/Q/zbEQ5LGKGeeamY/p8cVzTUPCm6VW3Kg1L5rf0UUGJHGZAeLMug9xDb8 9L8GmgOwci6Z2ORKwxf93CJok2wu3ifSOn3Dke1D7Umgs3IIU+54tEAP/HZL9pS0HaSH oH0Z3AMYDmqHuhCXNxYVpI+i+3fv9CVXVs53f8mVFVZL+n+10sXljKaAYHOiplJUaIyf Lankh2v+crucYPBx7mScbKVUSBRyWLHH9s6O+WwaDKP28jhdEHCGRe5BNYkwf+iccV5L Weew== X-Gm-Message-State: AOAM530aAs5CQ4BxvQnQ5b0QwZwVfSPUL2SLrBi7VBXu7LNuVMXYGi0p 0yXNAm+wxCcMgciGs0zfmWyLQg== X-Google-Smtp-Source: ABdhPJwr0gNNFQlPgQxrj29gX7WDwNo/WsIgKcZRbUKp6W9kl3YmWrARWy30SRdpqV5PhkhOYdC2HQ== X-Received: by 2002:a17:902:714e:b029:d3:b389:c0d2 with SMTP id u14-20020a170902714eb02900d3b389c0d2mr16437696plm.57.1602343461614; Sat, 10 Oct 2020 08:24:21 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t13sm15772811pjo.15.2020.10.10.08.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2020 08:24:21 -0700 (PDT) Date: Sat, 10 Oct 2020 08:24:13 -0700 From: Stephen Hemminger To: "Wei Hu (Xavier)" Cc: , Message-ID: <20201010082413.1c90098c@hermes.local> In-Reply-To: <20201010071212.24086-1-huwei013@chinasoftinc.com> References: <20201010071212.24086-1-huwei013@chinasoftinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: check if queue setupped in queue-related APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 10 Oct 2020 15:12:12 +0800 "Wei Hu (Xavier)" wrote: > + if (dev->data->rx_queues[rx_queue_id] == NULL) { > + RTE_ETHDEV_LOG(ERR, "Rx queue %"PRIu16" of device with port_id=%" > + PRIu16" has not been setupped\n", > + rx_queue_id, port_id); > + return -EINVAL; > + Please use correct spelling. Your change follows the existing style in rte_eth_dev_rx_queue_start() but my preference is that message strings are not split across lines. That makes it easier to use tools like grep to find messages in the source. Use of PRIu16 is not required. And recent compiler standards would require space around its use. Suggest: RTE_ETHDEV_LOG(ERR, "Queue %u of device with port_id=%u has not been setup\n", rx_queue_id, port_id);