From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACB2DA04B6; Mon, 12 Oct 2020 17:15:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B45E1D916; Mon, 12 Oct 2020 17:15:28 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 6694D1D8D1 for ; Mon, 12 Oct 2020 17:15:26 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id o8so8749371pll.4 for ; Mon, 12 Oct 2020 08:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wzV9v/UVBB2KsvwZlivo3Z6/LCARax5zHvQC4iy8SDM=; b=lklloCvhbQorsKbofQem7E8bWhBu+a6PHkrCTEP+uapE09c8GsY6PV3QzQOb3WWeVS ++H5hgO36S0/PA8UdAFlIPVNxMLHt517eT2JzXL4p9MimQB65Wp9ssLneT9ZhGTnq8Cn Ho1Tzwsj5+8gkVO5dAoUIqWXCtJtSM24vftleLT5IEPXHXTSxTFjlEgraZM53X4PGt+j HqLRnSoZRQKY6oqrKd7qnP4SGxQM+Wc0XOVbQxva6zmm0AHhfrhOeOj2Ulf7Ef0/vvTD RAT1OZnI9RfGoUCIEY1kvktn/HUw+B7JbvbTVoS4kPp6hySA51G0EUNRCRY3E/MXcVTe rW7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wzV9v/UVBB2KsvwZlivo3Z6/LCARax5zHvQC4iy8SDM=; b=C3DDCcTmdPueNP0osoxsTcLT7x55R5xnTQAaURwVtSJf4vs9nGOlWBf5KOL4nBGcVk Vc+tHyG/Le1JzhP1uyZi0v4P40Y4jSag2px78Az607v6jlCSIcpA6I4AZjxAhWCBxFPO YcoiHENKsoGKEQhLo9YZP8PQ7r1BX2cJPE92On3Tu0sJ9YcY1YCdrROKWlnAxDEbL7SF p6yldM95RQUBe27EawLH8jswC+mmX2k32IihohbnOZ3IEay3A1XZzG80hAaDN+nekssu tmF/tZF8E5gu/HyIxin5VI5OgXTUTvTPTvVyh1nXGRV52HRRJNhW2JFk1E93i6y0WEIf xFdQ== X-Gm-Message-State: AOAM532iehycNTIN3UfoTU4d89M8OLHQPvvkGfNlM6Hxi/+AjYOIQGlC PEcxMFQzV3VdR9igK6MiTqbYmQ== X-Google-Smtp-Source: ABdhPJwg5mS9WIrLOl7QGX7Hf76ViNPcqf5MV325Xo0F//qcsBdZm11DjAESyTsxHReEWole6xq/jg== X-Received: by 2002:a17:902:b696:b029:d2:1ebe:d80c with SMTP id c22-20020a170902b696b02900d21ebed80cmr23744206pls.18.1602515724568; Mon, 12 Oct 2020 08:15:24 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n2sm26267437pja.41.2020.10.12.08.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 08:15:24 -0700 (PDT) Date: Mon, 12 Oct 2020 08:15:16 -0700 From: Stephen Hemminger To: "Wei Hu (Xavier)" Cc: , Message-ID: <20201012081516.5b8560f5@hermes.local> In-Reply-To: <20201012073244.7447-1-huwei013@chinasoftinc.com> References: <20201010071212.24086-1-huwei013@chinasoftinc.com> <20201012073244.7447-1-huwei013@chinasoftinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] ethdev: check if queue setupped in queue-related APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 12 Oct 2020 15:32:44 +0800 "Wei Hu (Xavier)" wrote: > From: Chengchang Tang > > This patch adds checking whether the related Tx or Rx queue has been > setupped in the queue-related API functions to avoid illegal address > access. And validity check of the queue_id is also added in the API > functions rte_eth_dev_rx_intr_enable and rte_eth_dev_rx_intr_disable. > > Signed-off-by: Chengchang Tang > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Chengwen Feng Looks good. If you make another version (or when committing) Lets change the subject line and commit text to replace "setupped" since that is not an English word; the proper word would be setup. https://www.quora.com/What-is-the-past-tense-of-to-set-up-What-are-some-examples?share=1 Acked-by: Stephen Hemminger