From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE286A04B7; Tue, 13 Oct 2020 18:46:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D3DA51DC66; Tue, 13 Oct 2020 18:46:06 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0266F1DC51 for ; Tue, 13 Oct 2020 18:46:03 +0200 (CEST) IronPort-SDR: Q0vW5PrM/2vxdxrB7B24DwZrWbWQDg/TgVjD/X3TlxWJmQJEcBGCFDuIiBgpC3+yTqebFcTDfC fT8Ljlhm07Cw== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="145261772" X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="145261772" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 09:45:44 -0700 IronPort-SDR: vzaCKq3mA+AF/QG0dCEeHBwlWxixSLWK9LJQbcIgduFyQMYkb7Lg45IuMKlkjg89usTKNViHNG X6fNhV/RrDYw== X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="463558638" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.245.209]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Oct 2020 09:45:42 -0700 Date: Tue, 13 Oct 2020 17:45:39 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, Kevin Laatz Message-ID: <20201013164539.GH1496@bricha3-MOBL.ger.corp.intel.com> References: <20201013162820.6544-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013162820.6544-1-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH] test/telemetry: fix error handling for socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 13, 2020 at 05:28:20PM +0100, Ciara Power wrote: > When the socket connection failed, an error was printed to screen but > the function did not return an error, and continued to try read from the > socket. This is now corrected to close the socket and return -1 when the > connection fails. > > Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON") > > Signed-off-by: Ciara Power > --- Acked-by: Bruce Richardson