From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91ED4A04B7; Wed, 14 Oct 2020 11:24:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9321D1DD9B; Wed, 14 Oct 2020 11:24:01 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CA5711DB4F for ; Wed, 14 Oct 2020 11:23:56 +0200 (CEST) IronPort-SDR: HPHbqYtBdsl5b6EO02p/EDvLGqaGmvrCj7ebgXgelAJr8MuMOwUGmnz4zAt+YDLlGhdmG7pTjE DrJB71KB9CoA== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="227705499" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="227705499" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 02:23:54 -0700 IronPort-SDR: p3MZsBksYsly6V3iOnUX8tW/BLNv3r8+iii6TxYe15kuk1Z8gdGUuiV7IhmcSASo4XKVUZGUgX NXcbqPcTDgnw== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="463816645" Received: from bricha3-mobl.ger.corp.intel.com ([10.254.145.91]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Oct 2020 02:23:45 -0700 Date: Wed, 14 Oct 2020 10:23:38 +0100 From: Bruce Richardson To: "Burakov, Anatoly" Cc: "Guo, Jia" , "dev@dpdk.org" , "Ma, Liang J" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Ray Kinsella , Neil Horman , "Hunt, David" , "Ananyev, Konstantin" , "jerinjacobk@gmail.com" , "McDaniel, Timothy" , "Eads, Gage" , "Macnamara, Chris" Message-ID: <20201014092338.GC1513@bricha3-MOBL.ger.corp.intel.com> References: <1601647919-25312-1-git-send-email-liang.j.ma@intel.com> <931cbea6d091f16a51ad7eed736b4b6e69df93aa.1602258833.git.anatoly.burakov@intel.com> <05a92739-b0f5-5808-cedf-4fd1c4d44f97@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05a92739-b0f5-5808-cedf-4fd1c4d44f97@intel.com> Subject: Re: [dpdk-dev] [PATCH v5 04/10] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 10:07:09AM +0100, Burakov, Anatoly wrote: > On 14-Oct-20 4:10 AM, Guo, Jia wrote: > > > > > -----Original Message----- > > > From: dev On Behalf Of Anatoly Burakov > > > Sent: Saturday, October 10, 2020 12:02 AM > > > To: dev@dpdk.org > > > Cc: Ma, Liang J ; Thomas Monjalon > > > ; Yigit, Ferruh ; Andrew > > > Rybchenko ; Ray Kinsella > > > ; Neil Horman ; Hunt, David > > > ; Ananyev, Konstantin > > > ; jerinjacobk@gmail.com; Richardson, > > > Bruce ; McDaniel, Timothy > > > ; Eads, Gage ; > > > Macnamara, Chris > > > Subject: [dpdk-dev] [PATCH v5 04/10] ethdev: add simple power > > > management API > > > > > > From: Liang Ma > > > > > > Add a simple API to allow getting address of next RX descriptor from the > > > PMD, as well as release notes information. > > > > > > Signed-off-by: Liang Ma > > > Signed-off-by: Anatoly Burakov > > > --- > > Hi Jia, > > Thanks for your review. Responses below. > > > > > > > Notes: > > > v5: > > > - Bring function format in line with other functions in the file > > > - Ensure the API is supported by the driver before calling it (Konstantin) > > > > > > doc/guides/rel_notes/release_20_11.rst | 16 ++++++++++++++ > > > lib/librte_ethdev/rte_ethdev.c | 17 ++++++++++++++ > > > lib/librte_ethdev/rte_ethdev.h | 24 ++++++++++++++++++++ > > > lib/librte_ethdev/rte_ethdev_driver.h | 28 ++++++++++++++++++++++++ > > > lib/librte_ethdev/rte_ethdev_version.map | 1 + > > > 5 files changed, 86 insertions(+) > > > > > > diff --git a/doc/guides/rel_notes/release_20_11.rst > > > b/doc/guides/rel_notes/release_20_11.rst > > > index 808bdc4e54..e85af5d3e9 100644 > > > --- a/doc/guides/rel_notes/release_20_11.rst > > > +++ b/doc/guides/rel_notes/release_20_11.rst > > > @@ -55,6 +55,11 @@ New Features > > > Also, make sure to start the actual text at the margin. > > > ======================================================= > > > > > > +* **ethdev: add 1 new EXPERIMENTAL API for PMD power > > > management.** > > > + > > > + * ``rte_eth_get_wake_addr()`` > > > + * add new eth_dev_ops ``get_wake_addr`` > > > + > > > * **Updated Broadcom bnxt driver.** > > > > > > Updated the Broadcom bnxt driver with new features and improvements, > > > including: > > > @@ -136,6 +141,17 @@ New Features > > > * Extern objects and functions can be plugged into the pipeline. > > > * Transaction-oriented table updates. > > > > > > +* **Add PMD power management mechanism** > > > + > > > + 3 new Ethernet PMD power management mechanism is added through > > > > " mechanisms are " please. > > > > > + existing RX callback infrastructure. > > > + > > > + * Add power saving scheme based on UMWAIT instruction (x86 only) > > > + * Add power saving scheme based on ``rte_pause()`` > > > + * Add power saving scheme based on frequency scaling through the > > > + power library > > > + * Add new EXPERIMENTAL API > > > ``rte_power_pmd_mgmt_queue_enable()`` > > > + * Add new EXPERIMENTAL API > > > ``rte_power_pmd_mgmt_queue_disable()`` > > > + > > > > Could this doc be separate to other specific patch if it is not related with this patch? > > It is related - it's the doc changes that add mention of this API. I was > under the impression current policy was having doc updates in the same patch > as the changes made? > Yes, that is the case. Doc changes should be made alongside the relevant code changes.