From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Kevin Laatz <kevin.laatz@intel.com>
Subject: [dpdk-dev] [PATCH] raw/ioat: fix kvlist free
Date: Wed, 14 Oct 2020 11:09:48 +0100 [thread overview]
Message-ID: <20201014100948.1210209-1-kevin.laatz@intel.com> (raw)
There is a null pointer check in 'idxd_vdev_parse_params()' which is
causing a coverity issue. This check is redundant as the same check is
being done in 'rte_kvargs_free()', so it is simply removed in this patch.
In addition, kvlist was only being free'd on one path in this function.
This is fixed by always free'ing kvlist before returning.
Coverity issue: 363049
Fixes: 777edf43ae4f ("raw/ioat: introduce vdev probe for DSA/idxd device")
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
drivers/raw/ioat/idxd_vdev.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/raw/ioat/idxd_vdev.c b/drivers/raw/ioat/idxd_vdev.c
index 50d47d05c5..30a53b3b82 100644
--- a/drivers/raw/ioat/idxd_vdev.c
+++ b/drivers/raw/ioat/idxd_vdev.c
@@ -93,23 +93,21 @@ idxd_rawdev_parse_wq(const char *key __rte_unused, const char *value,
static int
idxd_vdev_parse_params(struct rte_kvargs *kvlist, struct idxd_vdev_args *args)
{
+ int ret = 0;
+
if (rte_kvargs_count(kvlist, IDXD_ARG_WQ) == 1) {
if (rte_kvargs_process(kvlist, IDXD_ARG_WQ,
&idxd_rawdev_parse_wq, args) < 0) {
IOAT_PMD_ERR("Error parsing %s", IDXD_ARG_WQ);
- goto free;
+ ret = -EINVAL;
}
} else {
IOAT_PMD_ERR("%s is a mandatory arg", IDXD_ARG_WQ);
- return -EINVAL;
+ ret = -EINVAL;
}
- return 0;
-
-free:
- if (kvlist)
- rte_kvargs_free(kvlist);
- return -EINVAL;
+ rte_kvargs_free(kvlist);
+ return ret;
}
static int
--
2.25.1
next reply other threads:[~2020-10-14 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:09 Kevin Laatz [this message]
2020-10-19 8:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014100948.1210209-1-kevin.laatz@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).