From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E20FCA04B7; Wed, 14 Oct 2020 13:35:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E1771DDDB; Wed, 14 Oct 2020 13:35:06 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0E64E1DAE7 for ; Wed, 14 Oct 2020 13:35:04 +0200 (CEST) IronPort-SDR: 3C3HEFXMkD0Nr9F9+wt4mM/mJoWBGO377LtUlU7TFKAu4HmVVkfhbSHtdJkWzCjbLLndw8EkYD AeP5AYHWi2Mg== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="162618117" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="162618117" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 04:35:00 -0700 IronPort-SDR: cpsG96TNEWByXheVI4qEhIseDcS0OGtHYtTchszKBrGwoAGqFZMoamBpPYCccT5gr/cO3IFfBA s9wiubZ/WJog== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="463849454" Received: from bricha3-mobl.ger.corp.intel.com ([10.254.145.91]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Oct 2020 04:34:59 -0700 Date: Wed, 14 Oct 2020 12:34:54 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org Message-ID: <20201014110010.GE1513@bricha3-MOBL.ger.corp.intel.com> References: <20201014101110.1210264-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014101110.1210264-1-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 11:11:10AM +0100, Kevin Laatz wrote: > The 'idxd' pointer in 'idxd_rawdev_destroy()' is being dereferenced before > it is checked. To fix this, the null pointer check was moved to occur > earlier in the code. > > Coverity issue: 363040 > Fixes: ff06fa2cf3ba ("raw/ioat: probe idxd PCI") > > Signed-off-by: Kevin Laatz > --- Acked-by: Bruce Richardson