From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A3E6A04DB; Thu, 15 Oct 2020 11:20:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E8641D72E; Thu, 15 Oct 2020 11:20:50 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1FF921D455 for ; Thu, 15 Oct 2020 11:20:48 +0200 (CEST) IronPort-SDR: NjiTTpCz9yQzrqUxChQwR2ZYeqUNyP7O8XUvQdzXsI/NVTitJHmkM+unTUjyucMOUlqLEcoj29 rGXCxhOhABaw== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="250995649" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="250995649" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 02:20:46 -0700 IronPort-SDR: u76il2m1I4WmANd9HNUiHzQNq3vxJC2VnVBQy/nttXaNB/5FPlSGTwcNPjWTX4qvq58430rMv8 QuSQ1132Bx7g== X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="531182458" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.245.94]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Oct 2020 02:20:45 -0700 Date: Thu, 15 Oct 2020 10:20:42 +0100 From: Bruce Richardson To: "Chen, BoX C" Cc: "dev@dpdk.org" , "Ma, LihongX" , Hemant Agrawal Message-ID: <20201015091221.GA537@bricha3-MOBL.ger.corp.intel.com> References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200903144942.671870-1-bruce.richardson@intel.com> <20201014142017.GI1513@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 09:55:18AM +0100, Chen, BoX C wrote: > Hi, Bruce > > Can this patch be merged before RC1? It is very helpful for our verification. > Thanks. > > Regards, > Chen Bo > Understood, however, it is not fully reviewed and acked, so if you have tested this whole set, please provide a tested-by tag in an email. Similarly if you, or others, have time to review the set please do and provide feedback and/or acks on it. /Bruce > > -----Original Message----- > > From: dev On Behalf Of Bruce Richardson > > Sent: October 14, 2020 22:20 > > To: dev@dpdk.org > > Cc: Ma, LihongX ; Hemant Agrawal > > > > Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time > > constants > > > > On Thu, Sep 03, 2020 at 03:49:39PM +0100, Bruce Richardson wrote: > > > A number of the more advanced DPDK build settings which are not > > > expected to be user modified are stored in config/rte_config.h. In > > > some cases, for a custom build a user may want to override those > > > settings via CFLAGS, so we need to ensure that the definitions do not > > > override the user-provided values. > > > > > > Bruce Richardson (3): > > > config: remove explicit undefinition of unset values > > > config: allow overriding some build defaults > > > doc: add notes on overriding extra config values > > > > > Ping for any further reviews or comments on this set?