From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2DDAA04DB; Thu, 15 Oct 2020 13:20:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA32F1E4B3; Thu, 15 Oct 2020 13:20:17 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0393F1E4A1; Thu, 15 Oct 2020 13:20:13 +0200 (CEST) IronPort-SDR: J154aFR3NxgZsyE+iz6uF+o4itri/0hhiI3o2DNr94DO1djVSXVQUbkiryq+UsWvv6SQo9gMd+ FEi0XhtQXS3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="145633119" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="145633119" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 04:20:07 -0700 IronPort-SDR: yZ0FxNLH7o3LJi8CDjzM8JRX7BqiW7PjwOZYKlg53ttygjgpzVPAD+/WYmGMO+yvPXZQ0plgQk OxP37cWbow3Q== X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="464259066" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.245.94]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Oct 2020 04:20:04 -0700 Date: Thu, 15 Oct 2020 12:20:00 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, david.marchand@redhat.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, thomas@monjalon.net, stable@dpdk.org Message-ID: <20201015112000.GC554@bricha3-MOBL.ger.corp.intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201014141304.632120-1-bruce.richardson@intel.com> <20201014141304.632120-4-bruce.richardson@intel.com> <9d06a3d9eb1792c02e909d44fdcfd527531c4848.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d06a3d9eb1792c02e909d44fdcfd527531c4848.camel@debian.org> Subject: Re: [dpdk-dev] [PATCH v3 3/7] build: add defines for compatibility with make build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 11:31:18AM +0100, Luca Boccassi wrote: > On Wed, 2020-10-14 at 15:13 +0100, Bruce Richardson wrote: > > The defines used to indicate what crypto, compression and eventdev drivers > > were being built were different to those used in the make build, with meson > > defining them with "_PMD" at the end, while make defined them with "_PMD" > > in the middle and the specific driver name at the end. This might cause > > compatibility issues for applications which used the older defines, which > > switching to build against new DPDK releases. > > > > As well as changing the default to match that of make, meson also > > special-cases the crypto/compression/event drivers to have both defines > > provided. This ensures compatibility for these macros with both meson and > > make from older versions. > > > > For a selection of other libraries and drivers, there were other > > incompatibilities between the meson and make-defined macros which were not > > previously highlighted in a deprecation notice, so we add per-macro > > compatibility defines for these to ease the transition from make to meson. > > > > Fixes: 5b9656b157d3 ("lib: build with meson") > > Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build") > > Fixes: dcadbbde8e61 ("crypto/null: build with meson") > > Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD") > > Fixes: eca504f318db ("drivers/event: build skeleton and SW drivers with meson") > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > --- > > app/test/meson.build | 1 + > > config/meson.build | 3 +- > > config/rte_compatibility_defines.h | 129 +++++++++++++++++++++++++++++ > > config/rte_config.h | 1 + > > drivers/compress/meson.build | 2 +- > > drivers/crypto/meson.build | 2 +- > > drivers/event/meson.build | 2 +- > > drivers/meson.build | 15 ++++ > > 8 files changed, 151 insertions(+), 4 deletions(-) > > create mode 100644 config/rte_compatibility_defines.h > > > > diff --git a/app/test/meson.build b/app/test/meson.build > > index dedf29dd7..fc90a1909 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -415,6 +415,7 @@ endif > > > > if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER') > > driver_test_names += 'cryptodev_scheduler_autotest' > > + test_deps += 'pmd_crypto_scheduler' > > endif > > > > foreach d:test_deps > > This change looks out of place in this patch? Was it supposed to be > part of one of the previous commits maybe? > > Other than that, > > Acked-by: Luca Boccassi > Yes, it looks like it probably should be. I'll investigate and do a v5 (since I had v4 already done before I saw this comment!) /Bruce