From: Bruce Richardson <bruce.richardson@intel.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export
Date: Fri, 16 Oct 2020 16:52:13 +0100 [thread overview]
Message-ID: <20201016155213.GA1121@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu>
On Fri, Oct 16, 2020 at 04:48:59PM +0100, Kinsella, Ray wrote:
>
> On 16/10/2020 12:22, David Marchand wrote:
> > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
> >>
> >>
> >> The windows exports and the map files, feels like duplication of effort.
> >> Could we massage one into the other during the build?
> >
> > That's what is done with map-to-win.py, unless we have one exception
> > when the full library is not ready, like EAL.
> >
> > https://git.dpdk.org/dpdk/tree/lib/meson.build#n152
> > https://git.dpdk.org/dpdk/tree/buildtools/map_to_win.py#n27
> >
>
> Thinking about this again - future work might be to check if a .def exists.
> And then to warn in checkpatch if one is modified without the other?
>
Possibly, but right now there is only the one .def override file, for EAL,
and a better use of effort is to close the gap between windows and other
versions so that it can be removed completely.
$ find lib/ drivers/ -name *.def
lib/librte_eal/rte_eal_exports.def
/Bruce
next prev parent reply other threads:[~2020-10-16 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:38 [dpdk-dev] [PATCH " David Marchand
2020-10-16 9:38 ` [dpdk-dev] [PATCH 2/2] devtools: check Windows export files David Marchand
2020-10-16 10:04 ` David Marchand
2020-10-16 10:17 ` [dpdk-dev] [PATCH 1/2] eal/windows: fix symbol export Thomas Monjalon
2020-10-16 10:27 ` [dpdk-dev] [PATCH v2 " David Marchand
2020-10-16 10:27 ` [dpdk-dev] [PATCH v2 2/2] devtools: check Windows export files David Marchand
2020-10-16 11:56 ` Thomas Monjalon
2020-10-16 12:00 ` David Marchand
2020-10-16 11:16 ` [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export Kinsella, Ray
2020-10-16 11:22 ` David Marchand
2020-10-16 11:23 ` Kinsella, Ray
2020-10-16 15:48 ` Kinsella, Ray
2020-10-16 15:52 ` Bruce Richardson [this message]
2020-10-16 16:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016155213.GA1121@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=konstantin.ananyev@intel.com \
--cc=ktraynor@redhat.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).