From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AC2EA04DD; Mon, 19 Oct 2020 10:33:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AFFAA9C6; Mon, 19 Oct 2020 10:33:51 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9EB21A9B7 for ; Mon, 19 Oct 2020 10:33:49 +0200 (CEST) IronPort-SDR: I9mgC4j7pacrB9eyPMGzfMohEPFAkjFH3pwRgR0hHIoF1tYSZBjr1OYh/+TzFkJpqEmh3+VQVw nnT+9epxPKVA== X-IronPort-AV: E=McAfee;i="6000,8403,9778"; a="167105733" X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="167105733" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 01:33:47 -0700 IronPort-SDR: DYc6JHYHeFG86q89RX/YUWd7z9nYem/Hk/3JesTtAv0LDp9CvuIW0ACKS8rra1U/RRcjKRUR/l Kmquzh63GSeA== X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="331826129" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.11.189]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Oct 2020 01:33:42 -0700 Date: Mon, 19 Oct 2020 09:33:37 +0100 From: Bruce Richardson To: Jerin Jacob Cc: Timothy McDaniel , John McNamara , Marko Kovacevic , Ray Kinsella , Neil Horman , dpdk-dev , Erik Gabriel Carrillo , Gage Eads , "Van Haaren, Harry" , Jerin Jacob , Thomas Monjalon Message-ID: <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-1-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > wrote: > > > > Adds the meson build infrastructure, which includes > > compile-time constants in rte_config.h. DLB2 is > > only supported on Linux X86 platforms at this time. > > > > Signed-off-by: Timothy McDaniel > > Reviewed-by: Gage Eads > > --- > > config/rte_config.h | 7 + > > doc/guides/eventdevs/dlb2.rst | 330 ++++++++++++++++++++++ > > doc/guides/eventdevs/index.rst | 1 + > > drivers/event/dlb2/meson.build | 7 + > > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 3 + > > drivers/event/meson.build | 3 + > > 6 files changed, 351 insertions(+) > > create mode 100644 doc/guides/eventdevs/dlb2.rst > > create mode 100644 drivers/event/dlb2/meson.build > > create mode 100644 drivers/event/dlb2/rte_pmd_dlb2_event_version.map > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > index 0bae630..fd1b3c3 100644 > > --- a/config/rte_config.h > > +++ b/config/rte_config.h > > @@ -131,4 +131,11 @@ > > /* QEDE PMD defines */ > > #define RTE_LIBRTE_QEDE_FW "" > > > > +/* DLB2 defines */ > > +#define RTE_LIBRTE_PMD_DLB2_POLL_INTERVAL 1000 > > +#define RTE_LIBRTE_PMD_DLB2_UMWAIT_CTL_STATE 0 > > +#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS > > +#define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 > > +#define RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 > > We are going way with GLOBAL compile time options for drivers. > I think, we should move to driver-specific folder not pollute top > level config file. > @Richardson, Bruce @Thomas Monjalon Thoughts? > Yes, we do need a better way to pass driver-specific build config options. How likely is it that the user may want to tweak these values? If it's not likely having them just as regular defines in the driver folder may be better, though they are not particularly problematic in rte_config.h given the number of other values already there. > > > + > > --- a/drivers/event/meson.build > > +++ b/drivers/event/meson.build > > @@ -10,6 +10,9 @@ if not (toolchain == 'gcc' and cc.version().version_compare('<4.8.6') and > > dpdk_conf.has('RTE_ARCH_ARM64')) > > drivers += 'octeontx' > > endif > > +if (dpdk_conf.has('RTE_ARCH_X86_64') and is_linux) > > + drivers += 'dlb2' > > +endif > > Please add the message in "Content Skipped" section, > Reference: grep "reason" in drivers/vdpa/mlx5/meson.build > The octeontx case is also wrong in this file, IMHO. Rather than checking things in the event level and adding things to the list, the list should just be static. If something should be optionally compiled, then check the conditions in the driver meson.build file itself and add "build=false" to disable, setting "reason" to the cause of it being disabled. This keeps all the logic about a driver in the other file, rather than someone having to look in multiple places for why something is or isn't getting built properly. Regards, /Bruce