DPDK patches and discussions
 help / color / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Ma Lihong <lihongx.ma@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants
Date: Mon, 19 Oct 2020 11:21:12 +0100
Message-ID: <20201019102112.GB649@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8ziDDa2oCr5phai4gZPR6JnETovEJ+HCtyVonfiS99MpQ@mail.gmail.com>

On Fri, Oct 16, 2020 at 06:46:12PM +0200, David Marchand wrote:
> On Fri, Oct 16, 2020 at 5:56 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > librte_eal.so is indeed built with the 64 value:
> > > $ pahole -C rte_mem_config build/install/lib64/librte_eal.so |grep memsegs
> > > die__process_function: tag not supported (INVALID)!
> > >     struct rte_memseg_list     memsegs[64];          /*   136  8704 */
> > >
> > >
> > > But no trace of the custom value for external applications:
> > > $ grep -r RTE_MAX_MEMSEG_LISTS build/install
> > > build/install/include/rte_config.h:#ifndef RTE_MAX_MEMSEG_LISTS
> > > build/install/include/rte_config.h:#define RTE_MAX_MEMSEG_LISTS 128
> > > Binary file build/install/lib64/librte_eal.a matches
> > > Binary file build/install/lib64/librte_eal.so.21.0 matches
> > >
> > > I can see the same using the meson option -Dc_args.
> > >
> >
> > Good point, I had not thought of external apps using these values.
> >
> > They are mostly for internal use, so maybe its worthwhile looking to not
> > have them in a public header file. What do you think? Is it likely that
> > apps would be using some of these values, or needs to know the specifics?
> 
> Some are publicly exposed, like RTE_MEMPOOL_CACHE_MAX_SIZE,
> RTE_PKTMBUF_HEADROOM, RTE_ETHDEV_RXTX_CALLBACKS,
> For those, either we propagate the overriden value to the installed
> rte_config.h or we refuse customisation.
> 
I'd suggest the first 2 of those should possibly be global meson options.
Third should probably not be exposed at all.

/Bruce

  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 11:44 [dpdk-dev] [PATCH 1/2] config: remove explicit undefinition of unset values Bruce Richardson
2020-08-25 11:44 ` [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults Bruce Richardson
2020-09-01  5:17   ` Ma, LihongX
2020-09-01  6:07     ` Hemant Agrawal
2020-09-01  9:02       ` Bruce Richardson
2020-09-03 14:50       ` Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-09-03 14:49   ` [dpdk-dev] [PATCH v2 1/3] config: remove explicit undefinition of unset values Bruce Richardson
2020-09-03 14:49   ` [dpdk-dev] [PATCH v2 2/3] config: allow overriding some build defaults Bruce Richardson
2020-09-03 14:49   ` [dpdk-dev] [PATCH v2 3/3] doc: add notes on overriding extra config values Bruce Richardson
2020-09-03 15:43     ` Hemant Agrawal
2020-10-14 14:20   ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-10-15  8:55     ` Chen, BoX C
2020-10-15  9:20       ` Bruce Richardson
2020-10-16 15:47   ` David Marchand
2020-10-16 15:55     ` Bruce Richardson
2020-10-16 16:46       ` David Marchand
2020-10-19 10:21         ` Bruce Richardson [this message]
2020-10-19 21:04           ` Thomas Monjalon
2020-10-20  8:34             ` Bruce Richardson
2020-10-20 10:04               ` Thomas Monjalon
2020-10-20 10:15                 ` Bruce Richardson
2020-10-28 16:32   ` Bruce Richardson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019102112.GB649@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox