From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01484A04DC; Tue, 20 Oct 2020 17:03:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 055ACBAF2; Tue, 20 Oct 2020 17:03:08 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 5340FA952 for ; Tue, 20 Oct 2020 17:03:05 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id 10so1342629pfp.5 for ; Tue, 20 Oct 2020 08:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yod5g+1Oj1CH0C7Wx3RblsOUYDuzLuAB6c57O1wnm9k=; b=PcYTb6r9WCsLKDkmN8vH3q07GazJQMpdH2nSCuoUcpt/npLWWn8oPLGRrboQinl5Pp h7BZZ3M2MVQTRYiVSYztZXv+0FPA9D4Vk1o4vrJO8C+K7gYqqfrEl/eaoGqoThvJgq+N 8q5FvnahOlb3F8GZrnP4NM60EMHMO2WVOHm67m7KDk8nfVaOgj59K6kG0InQWVZ6k/iB WFWtZxgQYYWMIHNaL+YCKAAPItMPsnNk5Cq+byM0a5J6Ssyku1SGhk41TJRSECfyPeSl UmhI5ZOBU+xnNBU8AQZ3p4YOjdNgI2c5qDqLd80/HhjaG5qlJujnKb7BQw6Xa+mOFFt2 1wXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yod5g+1Oj1CH0C7Wx3RblsOUYDuzLuAB6c57O1wnm9k=; b=CEUYYTZ9zqZh4rTBk+t5aKy5HnNJQ6aiYJBym64BJ1CGmUuYcoUciiphQwmIOQIDFv Wh4ssyRPloQxFvPbKl/mxE9Z3v29DcN0Xjxqfw4dcEkvOf/Gkls+4z0HfpUPUQ33vRwc nCsXlxO8OSKiT/vMaPkhmK+ezDFDFSceiYB3Ws2hYfTrwZOiliYoJiNDZ51wf0kiaXew O/59bTyMZZKsZYSFfb9gkbK4MLoXPoCNgRJuNPT0znJpHMdAQ2uE7ALb90iatHRD7jdb Ru1+0wGF0mLu4Fl5unSsLLlRmCkQNu7dBqHWcpBNpGuYnsqhTt+LKu1RZ+7gTFWuFKi4 uY9A== X-Gm-Message-State: AOAM531Qj20pjATylDbFCHyRbrPPxAmgeglMxpRxO8SqmZnL+uUqW/2C FvZmXsOxWt39OrEEwjjZwwlFoA== X-Google-Smtp-Source: ABdhPJy0b1AO5AkbphPX8d5BQJOFrzYsJJ6PdFysgU7wrXtbyCRzjXZ2uIIqI7a3wq3kT7L2OGm+uA== X-Received: by 2002:a63:1d4f:: with SMTP id d15mr3102871pgm.40.1603206183541; Tue, 20 Oct 2020 08:03:03 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x26sm2578990pfn.178.2020.10.20.08.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 08:03:03 -0700 (PDT) Date: Tue, 20 Oct 2020 08:02:55 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, bruce.richardson@intel.com Message-ID: <20201020080255.6d5023ab@hermes.local> In-Reply-To: <3266348.IbmaAm1IaQ@thomas> References: <20200702172852.6201-1-stephen@networkplumber.org> <20200904223118.10002-1-stephen@networkplumber.org> <3266348.IbmaAm1IaQ@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 20 Oct 2020 13:50:55 +0200 Thomas Monjalon wrote: > 05/09/2020 00:31, Stephen Hemminger: > > If using lots of queues and ports, and having per port or per queue > > metrics it is easy to exceed the upper bound of the metric library. > > Move the limit into rte_config where user can change it. > > > > Ideally, there would be no upper bound and a dynamic structure > > such as red-black tree or hash table would be used for these. > > > > Signed-off-by: Stephen Hemminger > > --- > > --- a/config/rte_config.h > > +++ b/config/rte_config.h > > +/* rte_metrics defines */ > > +#define RTE_METRICS_MAX_METRICS 256 > > Not sure we want to go in the direction of adding such tuning > in rte_config.h. > > The only other option is to rewrite rte_metrics to support a dynamic data structure!