From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD477A04DD; Tue, 20 Oct 2020 10:37:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5F445A26; Tue, 20 Oct 2020 10:37:11 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EB92A5A06 for ; Tue, 20 Oct 2020 10:37:08 +0200 (CEST) IronPort-SDR: nEGAteL3cV9o26xVW35ebvrmatXXVLnilKNutTAa1OolYiQycmIpb8hlZ+IQQOethDFWPmOLAn BRgDlbcf4w1A== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="163685814" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="163685814" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 01:37:07 -0700 IronPort-SDR: K5AI0TCiThDq0e2XgBSZGxDxGgowi6y7FmF1tsbVCdCQ0vb4fwKERMdRfceJ2iLdUb/4PiFdUn RoSEFqYCHzPA== X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="532967920" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.248.1]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Oct 2020 01:37:05 -0700 Date: Tue, 20 Oct 2020 09:37:01 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, bluca@debian.org, Andrew Rybchenko Message-ID: <20201020083701.GB558@bricha3-MOBL.ger.corp.intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201015150554.950838-1-bruce.richardson@intel.com> <20201015150554.950838-7-bruce.richardson@intel.com> <1932663.AIiTPRDKnh@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1932663.AIiTPRDKnh@thomas> Subject: Re: [dpdk-dev] [PATCH v5 6/8] devtools/test-null: load all drivers from directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 19, 2020 at 06:58:32PM +0200, Thomas Monjalon wrote: > 15/10/2020 17:05, Bruce Richardson: > > Rather than specifying specific drivers in the driver directory to load, we > > can just pass in the whole driver directory to the "-d" EAL flag, causing > > all drivers to load. This makes the load of driver independent of any > > specific driver names. > > > > Signed-off-by: Bruce Richardson > > --- > > --- a/devtools/test-null.sh > > +++ b/devtools/test-null.sh > > if ldd $testpmd | grep -q librte_ ; then > > export LD_LIBRARY_PATH=$build/drivers:$build/lib:$LD_LIBRARY_PATH > > - libs='-d librte_mempool_ring.so -d librte_pmd_null.so' > > + libs="-d $build/drivers" > > In this case, can we remove $build/drivers from LD_LIBRARY_PATH? > I think it's safer to keep it, as some drivers depend upon others, e.g. many NIC/crypto/etc drivers depend upon pci or vdev bus drivers. Therefore depending on the order in which the drivers load, they will have unmet dependencies which will be found by looking in LD_LIBRARY_PATH /Bruce