From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19CA4A04DC; Mon, 26 Oct 2020 15:53:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB97C1D9E; Mon, 26 Oct 2020 15:53:17 +0100 (CET) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 1818D100C for ; Mon, 26 Oct 2020 15:53:16 +0100 (CET) Received: by mail-pj1-f67.google.com with SMTP id l2so3217238pjt.5 for ; Mon, 26 Oct 2020 07:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NaNXospY075TD9SvspDIqZqhhmEFtaZXYnNHA0e3jdQ=; b=Qw08IskIOjjcuyxFwr/KBwBoCYiGyvLNaLI1gyIfYXrc/xDhh5G2DXDYxEzEThzPeO 2HDAf5SMhLPlhMHLvWajphjzQ+5D0B+Uve3aTxDqeCG+6hoz2oUXo9wK2hB/45eQzlUE CYY5BfoHt7a17Wux0YthfZQvoA/I1dkYuK1OsJJzqMpeV/EFODsNXsR8oi8E3L1pXEIE yFIkgxvCARK0A1/L6rqRZJ7HuY6scPGB59f9mU6FbnpKPx9gVZHYqAaPt4O1tr84hDqe U/rKojVtEqH8oSgSNcGY7J48A/SHi/iVxZ7Jm+C7WlvDHoHPTiuKmyaMZi3Cc2ZMn3qj JXfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NaNXospY075TD9SvspDIqZqhhmEFtaZXYnNHA0e3jdQ=; b=qhU3VOAPlwW1pN739qv6sb2jW1q8cNOhoWhd3Oa4Wjwftr1FEPrUr5ciMVfJgO6g8G 90LSHm+HhrkynP/GM2qyWxXwT+hrqsWFQ6lA/SqhxZQuDizCIfkwvAqRfDni2I3S4AgA oU/1faEzT47GIVBMBHzE90w3rUh4tTZnYG11E+BPokIlFK6leRYtGnApdBnIdN/n5Zox svOf/GFrNVHKu3IBtD7g3buPLQw6p+8B8RWhR0bCYVXK66Ezxp3yCBz2NJg5695Vwzm5 9DqJ4ajbJN0nOcPqkYeeE5mVYZagoNEQOJvBEZfpbXGe3up4PSbIxUe+ej6oECP3Aeky VE9A== X-Gm-Message-State: AOAM531gUO/cmHsRx4nsx8ciXd3KCVlljEkdGcexmzoeymcGNHGMz26r RWqu94dTYBDS0QhJo0g5IX/FFQ== X-Google-Smtp-Source: ABdhPJwx8VzeH29KABINewEFl10m9Rp6bEdiZ7W/5GU50/aF1h/0mQ2jfpvlgPxoohVL48jcMcCl+Q== X-Received: by 2002:a17:90a:e545:: with SMTP id ei5mr20177737pjb.60.1603723994212; Mon, 26 Oct 2020 07:53:14 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p188sm11027567pgp.65.2020.10.26.07.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 07:53:13 -0700 (PDT) Date: Mon, 26 Oct 2020 07:53:10 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: David Marchand , dev , "Yigit, Ferruh" , Bruce Richardson , Olivier Matz , Andrew Rybchenko , Akhil Goyal , John McNamara Message-ID: <20201026075310.76f01bfd@hermes.local> In-Reply-To: <5174433.N81YqoJXJ2@thomas> References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026052105.1561859-15-thomas@monjalon.net> <5174433.N81YqoJXJ2@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 14/15] examples/rxtx_callbacks: switch to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 26 Oct 2020 15:33:14 +0100 Thomas Monjalon wrote: > 26/10/2020 11:43, David Marchand: > > On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon wrote: > > > > > > The example used the deprecated mbuf field udata64. > > > It is moved to a dynamic field in order to allow removal of udata64. > > > > > > Note: RTE_MBUF_DYNFIELD_TIMESTAMP_NAME is an existing mbuf field name. > > > > I am a bit lost. > > How is this going to work as the mbuf timestamp field is used in this > > example too? > > Oh, you're right! > I will change the naming scheme to a custom "TSC" field. > > Since timestamp is still there why doesn't the example just use that?