From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D2A5BA04B5;
	Tue, 27 Oct 2020 06:55:33 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0E5792B9D;
	Tue, 27 Oct 2020 06:55:31 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 0EAE029C6
 for <dev@dpdk.org>; Tue, 27 Oct 2020 06:55:29 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 3F50B20B4905; Mon, 26 Oct 2020 22:55:27 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3F50B20B4905
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1603778127;
 bh=nUQl2csmDsGirWJxo7G9yXb0X4YdoRH8X4OUd9unQp4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=XSodshGgq7xnIbEn+KC4u5pbUTPs7wuotl/8QcS8uMWyGKsAN/4+Oyv5D8ecV0eK8
 m46KIKSJwGO1FpU8WPkOZkfsrbCGRZapJjZx/OZ/d1CH2PtxpaCMRqCTHlIWEQStWz
 hO9qb9XutX7sN3eIHUn/hBnx2ngHDs4DJ0Lx7/rE=
Date: Mon, 26 Oct 2020 22:55:27 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: rohit.raj@nxp.com
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>, dev@dpdk.org
Message-ID: <20201027055527.GA27989@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200826055233.26075-1-rohit.raj@nxp.com>
 <20201008153048.19369-1-rohit.raj@nxp.com>
 <20201008153048.19369-5-rohit.raj@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201008153048.19369-5-rohit.raj@nxp.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v4 5/5] eal/windows: added support for
	rte_bus_close API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 08, 2020 at 09:00:47PM +0530, rohit.raj@nxp.com wrote:
> From: Rohit Raj <rohit.raj@nxp.com>
> 
> Added support for rte_bus_close API on windows to reset the devices on
> the bus to default state.
> 
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> ---
>  lib/librte_eal/windows/eal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
> index bc48f27ab..9eb32077b 100644
> --- a/lib/librte_eal/windows/eal.c
> +++ b/lib/librte_eal/windows/eal.c
> @@ -251,7 +251,7 @@ rte_eal_cleanup(void)
>  {
>  	struct internal_config *internal_conf =
>  		eal_get_internal_configuration();
> -
> +	rte_bus_close();

Should we verify the return code here?

>  	eal_cleanup_config(internal_conf);
>  	return 0;
>  }