From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B739A04B5; Tue, 27 Oct 2020 10:32:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2AB22BD5; Tue, 27 Oct 2020 10:32:55 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 8B6B32BD3 for ; Tue, 27 Oct 2020 10:32:54 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id g12so1035429wrp.10 for ; Tue, 27 Oct 2020 02:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jwYqRzxWHvoUX4D0bY3kk86iOPve04pSLEZz6oY2ERA=; b=dx9E5Ki6YfJt6E/O/upxYWYywX2vO7WIM0Hmvym7lTc3DQJSd+oyqiflQHILRYJ8St JOPDFygBIjyU1+fHZqk0sGkEf658YPW0rDticyVR/EEuooN8dRBGgE5ttPQCiPp9/9OF OGBqoj5+P0buvI+mwifDbPYnGfOF/lzAVXF8Oj19Psi9z02Q0sLDtBIRQc62aCzLVIP3 /b8nVPo/OHhwxmuzis9cvKq14xr8p+xbPQFwpch528ntsXqCyCF6FOEglcZceWxlsLZg MDZl27ISEE74Q9cgjjBmLz5XO6YMl+0siCh/p6d3EXZxk4MMMGypvDKzskryao9gg249 XrZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jwYqRzxWHvoUX4D0bY3kk86iOPve04pSLEZz6oY2ERA=; b=Mr8np5Q226JqLoSxYBWZYxuSFGnZPVikoqi1OxnTAJJgP3/breBqAF6UGHL7VPC2Zl 1oZGllDvFDAsQSPE5xBCGVWHe0uJ+BGm1cZkLJ8dBmE3ZUU8hzG5b1cFblSuZOjFpeRq iNzejt2mAOTJDthQbRBCRS4bS4VOEWQpXuVkYcbNsc4zqvi0o7JTP+qAJBpUsLdwHfik Bo23p5U69WyqXVaHkLjVCbZgLtRJDU6zl+ZuV8L0ml8mBBlxP7G+/KDM2FjBGkYF6gL1 kdVib9BLnWy7exT2YZffxTQ2HZKNaFD4cvJUfaOpI+CqN2IcbpK/L6749QdEFVyjAqnk r5XA== X-Gm-Message-State: AOAM531HqOp/U/hdm7R2L4YjZuyOchH9MM9zh/94ccPMHCSgIN9rWE9D zV/1TJwuHun18R8YUvjAsmOzAQ== X-Google-Smtp-Source: ABdhPJyEmrU97M8t6hadMgrZ4Qq3c3C7PZtgUn3FfoDEgqV/IA+xECIVw+iCxRAjEFZKe3xeohQYyA== X-Received: by 2002:a05:6000:10:: with SMTP id h16mr1418035wrx.218.1603791173153; Tue, 27 Oct 2020 02:32:53 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id 1sm1306353wre.61.2020.10.27.02.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:32:52 -0700 (PDT) Date: Tue, 27 Oct 2020 10:32:51 +0100 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Nithin Dabilpuram , Pavan Nikhilesh Message-ID: <20201027093251.GN1898@platinum> References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-1-thomas@monjalon.net> <20201026222013.2147904-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026222013.2147904-5-thomas@monjalon.net> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 04/15] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On Mon, Oct 26, 2020 at 11:20:02PM +0100, Thomas Monjalon wrote: > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > It is moved to a dynamic field in order to allow removal of udata64. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_node/ip4_lookup.c | 7 +++++++ > lib/librte_node/ip4_rewrite.c | 10 ++++++++++ > lib/librte_node/node_private.h | 12 ++++++++++-- > 3 files changed, 27 insertions(+), 2 deletions(-) <...> > --- a/lib/librte_node/node_private.h > +++ b/lib/librte_node/node_private.h > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > > extern int rte_node_logtype; > #define NODE_LOG(level, node_name, ...) \ > @@ -21,7 +22,6 @@ extern int rte_node_logtype; > #define node_dbg(node_name, ...) NODE_LOG(DEBUG, node_name, __VA_ARGS__) > > /** > - * > * Node mbuf private data to store next hop, ttl and checksum. > */ > struct node_mbuf_priv1 { > @@ -37,6 +37,13 @@ struct node_mbuf_priv1 { > }; > }; > > +static const struct rte_mbuf_dynfield node_mbuf_priv1_dynfield_desc = { > + .name = "rte_node_dynfield_priv1", > + .size = sizeof(struct node_mbuf_priv1 *), > + .align = __alignof__(struct node_mbuf_priv1 *), > +}; > +extern int node_mbuf_priv1_dynfield_offset; > + It should be "struct node_mbuf_priv1", not "struct node_mbuf_priv1 *"