From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 826B3A04B5; Tue, 27 Oct 2020 12:05:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA5502E1E; Tue, 27 Oct 2020 12:05:07 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 002CB2C55 for ; Tue, 27 Oct 2020 12:05:05 +0100 (CET) IronPort-SDR: uEkmtPGc0CzvybvMoDCwHrRNS73ui7g5RvXQ59s5n8OvdkssGWAruw1e0yh6u8/oQAt9j64+kz +7kraqr8Xgnw== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="229697372" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="229697372" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 04:05:02 -0700 IronPort-SDR: dcW41160m+UbIuULPSJHv2/uP3JkGLbfK87VXjnIMCojquUfIziQyfJaHn9l0eAhQ3uPypYvCc ZAnLOmwyxv6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="355504548" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2020 04:04:55 -0700 Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com [10.237.217.48]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 09RB4tCw021730; Tue, 27 Oct 2020 11:04:55 GMT Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1]) by sivswdev09.ir.intel.com with ESMTP id 09RB4tkU019985; Tue, 27 Oct 2020 11:04:55 GMT Received: (from lma25@localhost) by sivswdev09.ir.intel.com with LOCAL id 09RB4rD8019981; Tue, 27 Oct 2020 11:04:53 GMT Date: Tue, 27 Oct 2020 11:04:53 +0000 From: "Liang, Ma" To: Thomas Monjalon Cc: dev@dpdk.org, anatoly.burakov@intel.com, viktorin@rehivetech.com, qi.z.zhang@intel.com, ruifeng.wang@arm.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, david.hunt@intel.com, jerinjacobk@gmail.com, nhorman@tuxdriver.com, timothy.mcdaniel@intel.com, gage.eads@intel.com, drc@linux.vnet.ibm.com Message-ID: <20201027110453.GA15973@sivswdev09.ir.intel.com> References: <1603494392-7181-11-git-send-email-liang.j.ma@intel.com> <2125071.1A0xf8Un5s@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2125071.1A0xf8Un5s@thomas> Subject: Re: [dpdk-dev] [PATCH v9 10/10] doc: update programmer's guide for power library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, all is fixed in v10. Regards Liang On 24 Oct 22:49, Thomas Monjalon wrote: > 24/10/2020 01:06, Liang Ma: > > Update programmer's guide to document PMD power management usage. > > > > Signed-off-by: Liang Ma > > Signed-off-by: Anatoly Burakov > > Acked-by: David Hunt > > --- > > doc/guides/prog_guide/power_man.rst | 42 +++++++++++++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > Why don't you update this doc in the patch 5 > adding the code in the power library? > > > > --- a/doc/guides/prog_guide/power_man.rst > > +++ b/doc/guides/prog_guide/power_man.rst > > @@ -192,6 +192,45 @@ User Cases > > ---------- > > The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA. > > > > +PMD Power Management API > > +------------------------ > > + > > Blank line missing below: > > > +Abstract > > +~~~~~~~~ > > +Existing power management mechanisms require developers to change application > > +design or change code to make use of it. The PMD power management API provides a > > +convenient alternative by utilizing Ethernet PMD RX callbacks, and triggering > > +power saving whenever empty poll count reaches a certain number. > > + > > Here you start a list of schemes, without introducing it. > > > + * UMWAIT/UMONITOR > > + > > + This power saving scheme will put the CPU into optimized power state and use > > + the UMWAIT/UMONITOR instructions to monitor the Ethernet PMD RX descriptor > > + address, and wake the CPU up whenever there's new traffic. > > + > > + * Pause > > + > > + This power saving scheme will use the `rte_pause` function to avoid busy > > + polling. > > + > > + * Frequency scaling > > + > > + This power saving scheme will use existing power library functionality to > > + scale the core frequency up/down depending on traffic volume. > > + > > + > > +.. note:: > > + > > + Currently, this power management API is limited to mandatory mapping of 1 > > + queue to 1 core (multiple queues are supported, but they must be polled from > > + different cores). > > + > > +API Overview for PMD Power Management > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Underlining is long enough... > ... but a blank line is missing after the title. > > > +* **Queue Enable**: Enable specific power scheme for certain queue/port/core > > + > > +* **Queue Disable**: Disable power scheme for certain queue/port/core > > >