* [dpdk-dev] [PATCH] ethdev: move non-offload capabilities
@ 2020-10-27 13:20 Thomas Monjalon
2020-10-27 14:39 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2020-10-27 13:20 UTC (permalink / raw)
To: dev; +Cc: stable, Ferruh Yigit, Andrew Rybchenko, Qi Zhang, Konstantin Ananyev
The definitions of RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP
and RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP were inserted
before the last comment of Tx offloads.
It is moved in a better place,
with comments moved to be before the definition.
A group comment is added to better describe device capabilities.
Fixes: cac923cfea47 ("ethdev: support runtime queue setup")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_ethdev/rte_ethdev.h | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index e341a08817..ba997f16ce 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1408,21 +1408,22 @@ struct rte_eth_conf {
#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000
/** Device supports outer UDP checksum */
#define DEV_TX_OFFLOAD_OUTER_UDP_CKSUM 0x00100000
-
/** Device supports send on timestamp */
#define DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP 0x00200000
-
-
-#define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001
-/**< Device supports Rx queue setup after device started*/
-#define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002
-/**< Device supports Tx queue setup after device started*/
-
/*
* If new Tx offload capabilities are defined, they also must be
* mentioned in rte_tx_offload_names in rte_ethdev.c file.
*/
+/**@{@name Device capabilities
+ * Non-offload capabilities reported in rte_eth_dev_info.dev_capa.
+ */
+/** Device supports Rx queue setup after device started. */
+#define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001
+/** Device supports Tx queue setup after device started. */
+#define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002
+/**@}*/
+
/*
* Fallback default preferred Rx/Tx port parameters.
* These are used if an application requests default parameters
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: move non-offload capabilities
2020-10-27 13:20 [dpdk-dev] [PATCH] ethdev: move non-offload capabilities Thomas Monjalon
@ 2020-10-27 14:39 ` Andrew Rybchenko
2020-10-27 16:33 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2020-10-27 14:39 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: stable, Ferruh Yigit, Qi Zhang, Konstantin Ananyev
On 10/27/20 4:20 PM, Thomas Monjalon wrote:
> The definitions of RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP
> and RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP were inserted
> before the last comment of Tx offloads.
>
> It is moved in a better place,
> with comments moved to be before the definition.
> A group comment is added to better describe device capabilities.
>
> Fixes: cac923cfea47 ("ethdev: support runtime queue setup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: move non-offload capabilities
2020-10-27 14:39 ` Andrew Rybchenko
@ 2020-10-27 16:33 ` Andrew Rybchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2020-10-27 16:33 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: stable, Ferruh Yigit, Qi Zhang, Konstantin Ananyev
On 10/27/20 5:39 PM, Andrew Rybchenko wrote:
> On 10/27/20 4:20 PM, Thomas Monjalon wrote:
>> The definitions of RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP
>> and RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP were inserted
>> before the last comment of Tx offloads.
>>
>> It is moved in a better place,
>> with comments moved to be before the definition.
>> A group comment is added to better describe device capabilities.
>>
>> Fixes: cac923cfea47 ("ethdev: support runtime queue setup")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-27 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 13:20 [dpdk-dev] [PATCH] ethdev: move non-offload capabilities Thomas Monjalon
2020-10-27 14:39 ` Andrew Rybchenko
2020-10-27 16:33 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).