From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6217A04B5; Fri, 30 Oct 2020 12:31:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B350DC882; Fri, 30 Oct 2020 12:31:40 +0100 (CET) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id 75F60C838 for ; Fri, 30 Oct 2020 12:31:36 +0100 (CET) Received: by mail-lf1-f65.google.com with SMTP id b1so7388863lfp.11 for ; Fri, 30 Oct 2020 04:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=do35Ojfs7P5Eq3rTEOxwuhZp4NF80o4dNpOz0Jd++sY=; b=0d77k7xHUjqgEneMdFL2ifwcR0gZ4Xqr3/Dw6ZjoJbLNjD47RJDqgmkNLr5wOJRKHr LymPqVmsLE+ttbUg+POpccAzHcR2NUgDv4m0dKEQLPLt5R9Hi/exqMRd+MlAi+dvx/Bq pRJHUm1bvUc4CHHSv4aar14I4Fot+mYkTEsMESbq8C3vNgazYk0t+5E8YM6gh09htQAG dkeIezpm1QLX12kNpBy7fWQGdG3WtWHxiI0RFINK6IhCkX8eag8b0KGX/TWCZFLkA7R+ NARe538nzTLGvGTWD7OlpEPpj9rrfAA8OHxBenVlmLenJBQzXodNSmUyQy9EFQmmqI5v CGsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=do35Ojfs7P5Eq3rTEOxwuhZp4NF80o4dNpOz0Jd++sY=; b=bqb2PLvCaO0LXZSv4Ki6xoLi84YtOzI8HJSF5JuuU8rGmy3+b9VSW3F+fNhIvwNSJC IRoir30PDSJAaeiVL9c4gLBJi2DhzvcMAVCRGy5oJy20kZMzqNd58pR5vIF/La49Nj4e 3pwmJbtfpdfwk4GetWt5RMajLyRBCTxFw4TR/8ZoecXjMabhLw1uGn/1JRoWMj1s/rvl FyerAOEfvicrfwsfTx1Vv8lRbCZV17HJeAhoHRJFoDeZh40oPHgsxYVVxuLb00bHxS5l P+F93wtHVxnL6zVO9h59yAHdIrVUgqmin3RMBTpzB4vNrSU0trE5AulFWDsBHDnjDifO C6hA== X-Gm-Message-State: AOAM531sD7rzeEv2Fz4v0YXgyrSLkztb+ZNPS3WQk8gbYxmATnk8NWxq o4w7KSC21CjTSjb9IaMrx4vj9F76vB7Hfw== X-Google-Smtp-Source: ABdhPJz7TJmxEZ4oAOiCwc4NUe7exTXEFS/Q95TTgEKFx+7NDdkIz6SUcag5XlU7+jzfrwgGu4qTmw== X-Received: by 2002:ac2:5dea:: with SMTP id z10mr812260lfq.468.1604057494836; Fri, 30 Oct 2020 04:31:34 -0700 (PDT) Received: from mkPC.int.semihalf.com (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id m11sm596965lfa.112.2020.10.30.04.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 04:31:33 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: mw@semihalf.com, igorch@amazon.com, gtzalik@amazon.com, Michal Krawczyk , stable@dpdk.org Date: Fri, 30 Oct 2020 12:31:16 +0100 Message-Id: <20201030113121.1310305-2-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201030113121.1310305-1-mk@semihalf.com> References: <20201030113121.1310305-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/6] net/ena: fix getting xstats global stats offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was a bug in a code, which was reading stat_offset value from the ena_stats_rx_strings array instead of ena_stats_global_strings. It wasn't causing real problems just because ena_stats_rx_strings was not smaller than ena_stats_global_strings and both arrays hold the same offsets. Fixes: 7830e905b7c9 ("net/ena: expose extended stats") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index c513faf202..7ab9b93ba9 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2724,7 +2724,7 @@ static int ena_xstats_get(struct rte_eth_dev *dev, return 0; for (stat = 0; stat < ENA_STATS_ARRAY_GLOBAL; stat++, count++) { - stat_offset = ena_stats_rx_strings[stat].stat_offset; + stat_offset = ena_stats_global_strings[stat].stat_offset; stats_begin = &adapter->dev_stats; xstats[count].id = count; -- 2.25.1