From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2BDEA04E6; Fri, 30 Oct 2020 19:44:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AF5DBC64; Fri, 30 Oct 2020 19:42:38 +0100 (CET) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 72E69A8E9 for ; Fri, 30 Oct 2020 19:42:36 +0100 (CET) Received: by mail-lj1-f196.google.com with SMTP id m8so1915612ljj.0 for ; Fri, 30 Oct 2020 11:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZhJ1VNitdqLGya1jU5OoftTmDlVLOkwqnf10cewR4NA=; b=CuTlxlWsmHhe/vJCR7rkzZNNAVcqmBLVICzFh02FU0+QVWTBkOt8V9TXDIKUH2H+wy IoWqV+ryM+RNLLkxXmYghkr9xWc7AVQ0loD/ZaKyhvIORlOrlJnnEdB/Bj4OAFn2pKzp 4IHwtD8HuLHBBai6Jxu2uSPuy/VR6xZNe1x8eCl8ykUH0xe79tAuutzANjjAErOMEMS3 AG/PI7ZlOBeOZkRWzpjdKOk4nic6tooWlfTwkZzaKzmfw9yg63wmMVQgQkTsV7OjE9mJ +Y84ZS1Y6sAMlAJfCA/aaSqnHmlxjkIV67M+keVz9u5vjyEUlbHKpIRPgX4lkiSw31gD p5qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZhJ1VNitdqLGya1jU5OoftTmDlVLOkwqnf10cewR4NA=; b=TvTGdk8eSq6JUaV84+SZdgVuujqFARLB7VHX+3y4bDpTu3bXLJ9tbRQO+khTvCRrGr LMvSMWheHANmlL+H6nOK1JO9TTQgh0m+vLcP9lwY6ll3aFldspa9bB4g1/FpVMTiTf1z znhkeugNwB+EsGDfeZ9JjvmjISQV88/aN22m953L+J1lqVOij374dl5XvydMb/o6i0Av hPLXOWsH39GkIqwdEdbzrHqEIYuynlCpS66xyDzBJjN9W0sVx19n960IQzw2OnjnFsjV TBhserIrq9mHfGU1sQULpuvFn/Rpj8TJ1wKW7Z8pmDyV02QteXxyA+AA13Wjl7X5X0Qp lq4A== X-Gm-Message-State: AOAM533aM3i2SA9wD30SokM+Y9BRGX2sWOsn69NLNXz/B474x0Khw4wz Fio6zqv412jrZnFsUoo5It6hrN244DkBrH7d X-Google-Smtp-Source: ABdhPJxAQw2Tqavgb+sGTyUgEn3Bg+XiNLIaaT6srA5+uFSydSwafqmAWWS0oCUkJx/FB6XLRRIk7Q== X-Received: by 2002:a2e:9048:: with SMTP id n8mr1651947ljg.289.1604083355622; Fri, 30 Oct 2020 11:42:35 -0700 (PDT) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id p14sm713086lfc.40.2020.10.30.11.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 11:42:35 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: "Kadam, Pallavi" , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy Date: Fri, 30 Oct 2020 21:42:16 +0300 Message-Id: <20201030184217.19098-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201030183113.17829-1-dmitry.kozliuk@gmail.com> References: <20201030183113.17829-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] eal/windows: fix deadlock when setting alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Windows alarms are both armed and executed from the interrupt thread. rte_eal_alarm_set() dispatched alarm-arming code to that thread and waited for its completion via a spinlock. However, if called from alarm callback (i.e. from the interrupt thread), this caused a deadlock, because arming could not be run until its dispatcher exits, but it could only exit after it finished waiting for arming to complete. Call arming code directly when running in the interrupt thread. Fixes: f4cbdbc7fbd2 ("eal/windows: implement alarm API") Reported-by: Pallavi Kadam Signed-off-by: Dmitry Kozlyuk --- v2: fix typo in description lib/librte_eal/windows/eal_alarm.c | 68 ++++++++++++++++++++---------- 1 file changed, 46 insertions(+), 22 deletions(-) diff --git a/lib/librte_eal/windows/eal_alarm.c b/lib/librte_eal/windows/eal_alarm.c index 3b262793a..f5bf88715 100644 --- a/lib/librte_eal/windows/eal_alarm.c +++ b/lib/librte_eal/windows/eal_alarm.c @@ -30,7 +30,7 @@ static LIST_HEAD(alarm_list, alarm_entry) alarm_list = LIST_HEAD_INITIALIZER(); static rte_spinlock_t alarm_lock = RTE_SPINLOCK_INITIALIZER; -static int intr_thread_exec(void (*func)(void *arg), void *arg); +static int intr_thread_exec_sync(void (*func)(void *arg), void *arg); static void alarm_remove_unsafe(struct alarm_entry *ap) @@ -57,6 +57,18 @@ alarm_callback(void *arg, DWORD low __rte_unused, DWORD high __rte_unused) rte_spinlock_unlock(&alarm_lock); } +static int +alarm_set(struct alarm_entry *entry, LARGE_INTEGER deadline) +{ + BOOL ret = SetWaitableTimer( + entry->timer, &deadline, 0, alarm_callback, entry, FALSE); + if (!ret) { + RTE_LOG_WIN32_ERR("SetWaitableTimer"); + return -1; + } + return 0; +} + struct alarm_task { struct alarm_entry *entry; LARGE_INTEGER deadline; @@ -64,14 +76,10 @@ struct alarm_task { }; static void -alarm_set(void *arg) +alarm_task_exec(void *arg) { struct alarm_task *task = arg; - - BOOL ret = SetWaitableTimer( - task->entry->timer, &task->deadline, - 0, alarm_callback, task->entry, FALSE); - task->ret = ret ? 0 : (-1); + task->ret = alarm_set(task->entry, task->deadline); } int @@ -80,14 +88,14 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg) struct alarm_entry *ap; HANDLE timer; FILETIME ft; - struct alarm_task task; + LARGE_INTEGER deadline; int ret; /* Calculate deadline ASAP, unit of measure = 100ns. */ GetSystemTimePreciseAsFileTime(&ft); - task.deadline.LowPart = ft.dwLowDateTime; - task.deadline.HighPart = ft.dwHighDateTime; - task.deadline.QuadPart += 10 * us; + deadline.LowPart = ft.dwLowDateTime; + deadline.HighPart = ft.dwHighDateTime; + deadline.QuadPart += 10 * us; ap = calloc(1, sizeof(*ap)); if (ap == NULL) { @@ -106,21 +114,37 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg) ap->timer = timer; ap->cb_fn = cb_fn; ap->cb_arg = cb_arg; - task.entry = ap; /* Waitable timer must be set in the same thread that will * do an alertable wait for the alarm to trigger, that is, - * in the interrupt thread. Setting can fail, so do it synchronously. + * in the interrupt thread. */ - ret = intr_thread_exec(alarm_set, &task); - if (ret < 0) { - RTE_LOG(ERR, EAL, "Cannot setup alarm in interrupt thread\n"); - goto fail; - } + if (rte_thread_is_intr()) { + /* Directly schedule callback execution. */ + ret = alarm_set(ap, deadline); + if (ret < 0) { + RTE_LOG(ERR, EAL, "Cannot setup alarm\n"); + goto fail; + } + } else { + /* Dispatch a task to set alarm into the interrupt thread. + * Execute it synchronously, because it can fail. + */ + struct alarm_task task = { + .entry = ap, + .deadline = deadline, + }; + + ret = intr_thread_exec_sync(alarm_task_exec, &task); + if (ret < 0) { + RTE_LOG(ERR, EAL, "Cannot setup alarm in interrupt thread\n"); + goto fail; + } - ret = task.ret; - if (ret < 0) - goto fail; + ret = task.ret; + if (ret < 0) + goto fail; + } rte_spinlock_lock(&alarm_lock); LIST_INSERT_HEAD(&alarm_list, ap, next); @@ -196,7 +220,7 @@ intr_thread_entry(void *arg) } static int -intr_thread_exec(void (*func)(void *arg), void *arg) +intr_thread_exec_sync(void (*func)(void *arg), void *arg) { struct intr_task task; int ret; -- 2.28.0