From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2F7B2A04E6;
	Sat, 31 Oct 2020 01:00:28 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7C8AEC7EE;
	Sat, 31 Oct 2020 01:00:26 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 11D06C778
 for <dev@dpdk.org>; Sat, 31 Oct 2020 01:00:24 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1061)
 id 653D120B4905; Fri, 30 Oct 2020 17:00:22 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 653D120B4905
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1604102422;
 bh=XslKsRQD5bLNKZd+PHIGqq18oWFVf0F2yYrtUqhwoMY=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=r61O/EWB65OIfuKpOsJwWOma/8ylqx4XmveuaL1lOg9uCZ0LPaN6St8LCmBxVTSVk
 hRYLCad/mrDcdUIQizSOFrCYgaSc8DmRiBQklETcVL/0peVgPxjLkAZnEImiBXTqjw
 iBX+B5XZ7BGuff8iR9mSF1EAKhK698NOBbGP1Qe8=
Date: Fri, 30 Oct 2020 17:00:22 -0700
From: Jie Zhou <jizh@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Jie Zhou <jizh@microsoft.com>,
 Ranjit Menon <ranjit.menon@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Beilei Xing <beilei.xing@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>,
 Ori Kam <orika@nvidia.com>, Radu Nicolau <radu.nicolau@intel.com>,
 Akhil Goyal <akhil.goyal@nxp.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, David Hunt <david.hunt@intel.com>
Message-ID: <20201031000022.GA13205@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200902183805.5421-1-dmitry.kozliuk@gmail.com>
 <20201030010126.17928-1-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201030010126.17928-1-dmitry.kozliuk@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v3] cmdline: avoid name clash with Windows
 system types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 30, 2020 at 04:01:26AM +0300, Dmitry Kozlyuk wrote:
> cmdline_numtype member names clash with Windows system identifiers.
> Add RTE_ prefix to cmdline constants to avoid this and possible
> future conflicts.
> 
> Suggested-by: Ranjit Menon <ranjit.menon@intel.com>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> 
> v3: change prefix from CMDLINE_ to RTE_ (Bruce Richardson)
> 
>  app/test-cmdline/commands.c                   |   2 +-
>  app/test-pmd/bpf_cmd.c                        |   8 +-
>  app/test-pmd/cmdline.c                        | 705 +++++++++---------
>  app/test-pmd/cmdline_flow.c                   |   2 +-
>  app/test-pmd/cmdline_mtr.c                    |  89 +--
>  app/test-pmd/cmdline_tm.c                     | 196 ++---
>  app/test/test_cmdline_num.c                   |  48 +-
>  examples/ethtool/ethtool-app/ethapp.c         |  19 +-
>  examples/ipsec-secgw/parser.c                 |   2 +-
>  examples/qos_sched/cmdline.c                  |  46 +-
>  examples/vdpa/main.c                          |   2 +-
>  .../guest_cli/vm_power_cli_guest.c            |   2 +-
>  examples/vm_power_manager/vm_power_cli.c      |   8 +-
>  lib/librte_cmdline/cmdline_parse_num.c        |  65 +-
>  lib/librte_cmdline/cmdline_parse_num.h        |  16 +-
>  15 files changed, 618 insertions(+), 592 deletions(-)

Acked-by: Jie Zhou <jizh@microsoft.com>
Tested-by: Jie Zhou <jizh@microsoft.com>