From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01968A0521; Mon, 2 Nov 2020 12:35:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E7F6C7FC; Mon, 2 Nov 2020 12:35:42 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id E75E0C7FA for ; Mon, 2 Nov 2020 12:35:40 +0100 (CET) Received: from localhost.localdomain (unknown [188.242.7.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6D72D7F51A; Mon, 2 Nov 2020 14:35:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6D72D7F51A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1604316939; bh=3K/J/Qbit+Nl2SKSYgGHv0V7GChlVNHs7s6jBZpHCrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=B2wvgiGiTSbLfP0lCyJTTHsWMquGzcdF/P6uuBD952I+pLP/88qErY4w7OxElfnp2 9thL7+bj1uLQuxXK3LUNnqldKcNf/etT8btNbN6mzQquQciU3ZCwdXeyLaJE6Zibn+ sDVETbDzFCU5HvqMXafbSIFwT3SzQ1RkgMf5I4qA= From: Ivan Malov To: dev@dpdk.org Cc: Xueming Li , Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Date: Mon, 2 Nov 2020 14:35:18 +0300 Message-Id: <20201102113519.23412-1-ivan.malov@oktetlabs.ru> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201029114644.22169-1-ivan.malov@oktetlabs.ru> References: <20201029114644.22169-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce transfer attribute to shared action conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In a flow rule, attribute "transfer" means operation level at which both traffic is matched and actions are conducted. Add the very same attribute to shared action configuration. If a driver needs to prepare HW resources in two different ways, depending on the operation level, in order to set up an action, then this new attribute will indicate the level. Also, when handling a flow rule insertion, the driver will be able to turn down a shared action if its level is unfit. Signed-off-by: Ivan Malov Acked-by: Ori Kam --- ...-transfer-attribute-to-shared-action.patch | 42 ++++++++++ ...ort-shared-flow-action-attribute-tra.patch | 82 +++++++++++++++++++ lib/librte_ethdev/rte_flow.h | 8 ++ 3 files changed, 132 insertions(+) create mode 100644 0001-ethdev-introduce-transfer-attribute-to-shared-action.patch create mode 100644 0002-app-testpmd-support-shared-flow-action-attribute-tra.patch diff --git a/0001-ethdev-introduce-transfer-attribute-to-shared-action.patch b/0001-ethdev-introduce-transfer-attribute-to-shared-action.patch new file mode 100644 index 000000000..b0bf9063e --- /dev/null +++ b/0001-ethdev-introduce-transfer-attribute-to-shared-action.patch @@ -0,0 +1,42 @@ +From 802259bb546259663f979fb7695b8a9fd15bed31 Mon Sep 17 00:00:00 2001 +From: Ivan Malov +Date: Thu, 29 Oct 2020 06:54:46 +0300 +Subject: [PATCH 1/2] ethdev: introduce transfer attribute to shared action + conf + +In a flow rule, attribute "transfer" means operation level +at which both traffic is matched and actions are conducted. + +Add the very same attribute to shared action configuration. +If a driver needs to prepare HW resources in two different +ways, depending on the operation level, in order to set up +an action, then this new attribute will indicate the level. +Also, when handling a flow rule insertion, the driver will +be able to turn down a shared action if its level is unfit. + +Signed-off-by: Ivan Malov +--- + lib/librte_ethdev/rte_flow.h | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h +index a8eac4deb..0b993d8eb 100644 +--- a/lib/librte_ethdev/rte_flow.h ++++ b/lib/librte_ethdev/rte_flow.h +@@ -3487,6 +3487,13 @@ struct rte_flow_shared_action_conf { + /**< Action valid for rules applied to ingress traffic. */ + uint32_t egress:1; + /**< Action valid for rules applied to egress traffic. */ ++ ++ /** ++ * This attribute matches that of the flow rules which ++ * are supposed to comprise the given shared action. ++ * See struct rte_flow_attr. ++ */ ++ uint32_t transfer:1; + }; + + /** +-- +2.20.1 + diff --git a/0002-app-testpmd-support-shared-flow-action-attribute-tra.patch b/0002-app-testpmd-support-shared-flow-action-attribute-tra.patch new file mode 100644 index 000000000..d503d5d45 --- /dev/null +++ b/0002-app-testpmd-support-shared-flow-action-attribute-tra.patch @@ -0,0 +1,82 @@ +From 9732bc93169af1040731a4a66bd6ef44a878576b Mon Sep 17 00:00:00 2001 +From: Ivan Malov +Date: Thu, 29 Oct 2020 12:42:11 +0300 +Subject: [PATCH 2/2] app/testpmd: support shared flow action attribute + transfer + +This attribute helps PMDs to tell actions supposed to work +on the so-called hardware e-switch level from regular ones. + +Signed-off-by: Ivan Malov +--- + app/test-pmd/cmdline_flow.c | 12 ++++++++++++ + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- + 2 files changed, 13 insertions(+), 1 deletion(-) + +diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c +index c68d22fda..fe18cca27 100644 +--- a/app/test-pmd/cmdline_flow.c ++++ b/app/test-pmd/cmdline_flow.c +@@ -114,6 +114,7 @@ enum index { + SHARED_ACTION_CREATE_ID, + SHARED_ACTION_INGRESS, + SHARED_ACTION_EGRESS, ++ SHARED_ACTION_TRANSFER, + SHARED_ACTION_SPEC, + + /* Shared action destroy arguments */ +@@ -782,6 +783,7 @@ static const enum index next_sa_create_attr[] = { + SHARED_ACTION_CREATE_ID, + SHARED_ACTION_INGRESS, + SHARED_ACTION_EGRESS, ++ SHARED_ACTION_TRANSFER, + SHARED_ACTION_SPEC, + ZERO, + }; +@@ -4286,6 +4288,12 @@ static const struct token token_list[] = { + .next = NEXT(next_sa_create_attr), + .call = parse_sa, + }, ++ [SHARED_ACTION_TRANSFER] = { ++ .name = "transfer", ++ .help = "affect rule to transfer", ++ .next = NEXT(next_sa_create_attr), ++ .call = parse_sa, ++ }, + [SHARED_ACTION_SPEC] = { + .name = "action", + .help = "specify action to share", +@@ -4521,6 +4529,9 @@ parse_sa(struct context *ctx, const struct token *token, + case SHARED_ACTION_INGRESS: + out->args.vc.attr.ingress = 1; + return len; ++ case SHARED_ACTION_TRANSFER: ++ out->args.vc.attr.transfer = 1; ++ return len; + default: + return -1; + } +@@ -7273,6 +7284,7 @@ cmd_flow_parsed(const struct buffer *in) + &((const struct rte_flow_shared_action_conf) { + .ingress = in->args.vc.attr.ingress, + .egress = in->args.vc.attr.egress, ++ .transfer = in->args.vc.attr.transfer, + }), + in->args.vc.actions); + break; +diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst +index 289df193b..ebf7e68f8 100644 +--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst ++++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst +@@ -4318,7 +4318,7 @@ Creating shared actions + shared action ID. It is bound to ``rte_flow_shared_action_create()``:: + + flow shared_action {port_id} create [action_id {shared_action_id}] +- [ingress] [egress] action {action} / end ++ [ingress] [egress] [transfer] action {action} / end + + If successful, it will show:: + +-- +2.20.1 + diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index a8eac4deb..8b970ba0b 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -3487,6 +3487,14 @@ struct rte_flow_shared_action_conf { /**< Action valid for rules applied to ingress traffic. */ uint32_t egress:1; /**< Action valid for rules applied to egress traffic. */ + + /** + * When set to 1, indicates that the action is valid for + * transfer traffic; otherwise, for non-transfer traffic. + * + * See struct rte_flow_attr. + */ + uint32_t transfer:1; }; /** -- 2.20.1