From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5613A04E7; Mon, 2 Nov 2020 16:41:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 400EAC948; Mon, 2 Nov 2020 16:41:51 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 8391DC948 for ; Mon, 2 Nov 2020 16:41:48 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id d142so1220047wmd.4 for ; Mon, 02 Nov 2020 07:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=epw9VnNKCKGkT0m3aUBXa6Q7/P5/zG9qJ+CwEpPbGUk=; b=GJH7GtiYoosL7phnojXUgrYjOVem1+CuV+nD+qccpebxdDd0p6kMwEis3QJdNENZuk /QyEJB+1VKKIdhtC4MLYST6jq5/ooyV+xPNhI+Pdxl+M5BF7/4p7ihxm6ttx7ZoNKCUD Y3rl5xrolDHjPrbBaxjnIfJ26DqE835EmAzuMI6SuL/MfNf+stLiovJZ5mFZYd9jyQAb MPam4hgKqd12qix0oEFRB7YmLxDhm6ZEbhbvElatKfu236lBBuqDSadhCU3wr5GIDLB8 xJ8DnD9+JfQg3vmCxnmc3Qk3ItD5Oj8Bndzih4w2iWTiPjniWDj+zicjwx55/Wx9qcVF WC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=epw9VnNKCKGkT0m3aUBXa6Q7/P5/zG9qJ+CwEpPbGUk=; b=oUYlZYCmzZ/9Xyjq0Iny9ayyruLSDt7dvm+wxZ4tdXJ3IjfQOoQUCe6kCYVyP/n5Ey uD3Ufi/yNdzT65FCIjNQMQcllmwcGMOhid39Cl50xLhsqx2jWYLGb1k8GdcQ/29gj83A 4/LTSifu7byy2LHZXXXsZktmZKnKRiWEw8QXZhD6Bk+TbCF9GicytfO5TOpNb8tz4Ug5 JJWn85AidJeRgQiJcqB2hIB+bZL479hqxJPTNvlyYN9Qgeghvve77cRTvNRd5UaOKPMT oXHTgM+zuvBlj2qVr1z/3vhVe7gC/tf4ovLQgGGmqhI9FlrOlnokyKNkwSYR1uUZmG7d v2Cg== X-Gm-Message-State: AOAM531GXr1b8Je6DUoC0NOWKHjRnKJgt/hLxdAB2duESWFjOE+37xQ9 rYic0xQGLqssYMbNgWJ5QY/CGPFjAwL37YyZ X-Google-Smtp-Source: ABdhPJyoJ/IYjmUip6rM+vJ1XirGBCw5EfDw0jfGApIeFFos5jc/TlFjfF6QIr8V+OYSw791heOBqA== X-Received: by 2002:a1c:c90b:: with SMTP id f11mr18431587wmb.54.1604331707276; Mon, 02 Nov 2020 07:41:47 -0800 (PST) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id e25sm24818387wrc.76.2020.11.02.07.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 07:41:46 -0800 (PST) Date: Mon, 2 Nov 2020 16:41:46 +0100 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com, Ajit Khaparde , Ray Kinsella , Neil Horman Message-ID: <20201102154146.GA1898@platinum> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201101180626.2198868-1-thomas@monjalon.net> <20201101180626.2198868-15-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101180626.2198868-15-thomas@monjalon.net> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 14/14] mbuf: remove deprecated timestamp field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Nov 01, 2020 at 07:06:26PM +0100, Thomas Monjalon wrote: > As announced in the deprecation note, the field timestamp > is removed to give more space to the dynamic fields. > The related offload flag PKT_RX_TIMESTAMP is also removed. > > This is how the mbuf layout looks like (pahole-style): > > word type name byte size > 0 void * buf_addr; /* 0 + 8 */ > 1 rte_iova_t buf_iova /* 8 + 8 */ > /* --- RTE_MARKER64 rearm_data; */ > 2 uint16_t data_off; /* 16 + 2 */ > uint16_t refcnt; /* 18 + 2 */ > uint16_t nb_segs; /* 20 + 2 */ > uint16_t port; /* 22 + 2 */ > 3 uint64_t ol_flags; /* 24 + 8 */ > /* --- RTE_MARKER rx_descriptor_fields1; */ > 4 uint32_t union packet_type; /* 32 + 4 */ > uint32_t pkt_len; /* 36 + 4 */ > 5 uint16_t data_len; /* 40 + 2 */ > uint16_t vlan_tci; /* 42 + 2 */ > 5.5 uint64_t union hash; /* 44 + 8 */ > 6.5 uint16_t vlan_tci_outer; /* 52 + 2 */ > uint16_t buf_len; /* 54 + 2 */ > 7 uint64_t dynfield0[1]; /* 56 + 8 */ > /* --- RTE_MARKER cacheline1; */ > 8 struct rte_mempool * pool; /* 64 + 8 */ > 9 struct rte_mbuf * next; /* 72 + 8 */ > 10 uint64_t union tx_offload; /* 80 + 8 */ > 11 struct rte_mbuf_ext_shared_info * shinfo; /* 88 + 8 */ > 12 uint16_t priv_size; /* 96 + 2 */ > uint16_t timesync; /* 98 + 2 */ > 12.5 uint32_t dynfield1[7]; /* 100 + 28 */ > 16 /* --- END 128 */ > > Signed-off-by: Thomas Monjalon > Reviewed-by: Andrew Rybchenko > Acked-by: Ajit Khaparde > Acked-by: Ray Kinsella <...> > --- a/lib/librte_mbuf/rte_mbuf_core.h > +++ b/lib/librte_mbuf/rte_mbuf_core.h > @@ -149,11 +149,6 @@ extern "C" { > */ > #define PKT_RX_LRO (1ULL << 16) > > -/** > - * Indicate that the timestamp field in the mbuf is valid. > - */ > -#define PKT_RX_TIMESTAMP (1ULL << 17) > - > /** > * Indicate that security offload processing was applied on the RX packet. > */ nit: can we keep a comment here to highlight the flag 17 is unused?