From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2907EA0521; Tue, 3 Nov 2020 18:42:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D5721DBD; Tue, 3 Nov 2020 18:42:48 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 9D426100C for ; Tue, 3 Nov 2020 18:42:46 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id o3so14212551pgr.11 for ; Tue, 03 Nov 2020 09:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r16Ohp3yQi3GAixfZdLZ2+a84iruSWeaBTOoTR2Je5I=; b=YN+RPbCbygvLnj23IoYDQ5i0dXRECthhkNNs8xY4zodP1ngzGkugI70yPLB6Xeu5Qi Av70FgJdR2mC0835OkuB4bA0PASLY0gg0s2MSDY4XFrHAzjSdXZ9sEcR4LLVwEasyXOw fC77FeWgMLTeUfRqtYWUrlcqQonmqh0bBNf3DNKGSfVNDC/4ZgN8FzfkCGI2tVOCn5AV CaxnR7XQsx7hbijWS60eokrGop3eo7nyTCRQ/A7Gy7ZADq8XLktXC+tCoYxWFLQjiVHd oKbrtW/xk0/lB626fcnoR6+hcUEOLrgF6lkzN8kg+R9xTuRrtFLnaqmq8C1MbeehsdXi xplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r16Ohp3yQi3GAixfZdLZ2+a84iruSWeaBTOoTR2Je5I=; b=p8MEMWjielDT1q2fua5jOGbY6s1e8bhYwNV8QRqp6EUU4+yZ5BzWcamV6/ZaaJ0lBE UsiHXLl9H8YctsQv8eLL9qub5CdhTihDaf5SXSp1l5czfw/93Iyyt/3sf8uFpe0gW6nM /3tCoT6j1EEF1/IIxlxXkXOWaS7O8NQ2KhjPLZ8aC5Wx3/t79R5QogrXW4IVU5i/4A3Z ygIhPKB6RfJ6DsBn/xqq+GvdzrjuRD1HDD3KUYW/Be+1hNxfrPIdMdfqkEkRw+QZzHQE yu7D5tm2YjsKsX/eKfZ+Rkj63qTI9+DtpAOg9onlZZIwBBMZKaEaHaP+mmsUYoRNurDe Bj3A== X-Gm-Message-State: AOAM531g2l482E7U+CMs7rEFXrV9spCdF98SZ4f1inJp1ah+6LzMMzKi cEQkWSYzRLtWL1y+pjDDLJD5tQ== X-Google-Smtp-Source: ABdhPJyNVpzf4Bg4wek2AY61WapdwOXMxdjXnB7c5wPewWVqchIGAjqCRC9/VOyP5ryLNohoygs9Yw== X-Received: by 2002:a62:ee06:0:b029:164:20d:183b with SMTP id e6-20020a62ee060000b0290164020d183bmr26996672pfi.4.1604425364765; Tue, 03 Nov 2020 09:42:44 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s145sm6553490pfs.187.2020.11.03.09.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 09:42:44 -0800 (PST) Date: Tue, 3 Nov 2020 09:42:36 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com Message-ID: <20201103094236.7845f0eb@hermes.local> In-Reply-To: <35654921.Wzvq2zENnk@thomas> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201103140931.488700-1-thomas@monjalon.net> <20201103080839.4d7d50ab@hermes.local> <35654921.Wzvq2zENnk@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 00/16] remove mbuf timestamp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 03 Nov 2020 17:20:20 +0100 Thomas Monjalon wrote: > 03/11/2020 17:08, Stephen Hemminger: > > On Tue, 3 Nov 2020 15:09:15 +0100 > > Thomas Monjalon wrote: > > > > > The mbuf field timestamp was announced to be removed for three reasons: > > > - a dynamic field already exist, used for Tx only > > > - this field always used 8 bytes even if unneeded > > > - this field is in the first half (cacheline) of mbuf > > > > > > After this series, the dynamic field timestamp is used for both Rx and Tx > > > with separate dynamic flags to distinguish when the value is meaningful > > > without resetting the field during forwarding. > > > > There should be a place in documentation which describes all the > > dynamic fields and their meaning. For example, which drivers/features > > set the field and the exact meaning. > > A dynamic field can be registered by anyone, including the apps. > So you will never get a full list. > The meaning of each field should be defined in its context > (driver, lib or app). > > > Is the timestamp in HW units, UTC units, or TSC ticks? > > The timestamp unit is driver-specific. > It is explained in ethdev API: > http://doc.dpdk.org/api/rte__ethdev_8h.html#a4346bf07a0d302c9ba4fe06baffd3196 Are there are any conventions we should use in this area? There could be overlapping usage between subsystems?