From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EAE0A0521; Tue, 3 Nov 2020 11:27:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4FF1C936; Tue, 3 Nov 2020 11:27:53 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0B588C934 for ; Tue, 3 Nov 2020 11:27:50 +0100 (CET) IronPort-SDR: cWeL+BP0J/Ie4R+UlOCu4dK26GZOvAX52icBvOnJb573qsoP6rYFpZbKH6m3cXCgsAHtheqprS 1x1d5NqSfC3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="165527693" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="165527693" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 02:27:49 -0800 IronPort-SDR: 8uhORAX0J36zjeYShick3n/KDa2jHXzonDWbSIBg2grkZMhNoKRpVvjaSMjh4O4eJn9eQMIljB sQYIdx3/PI7Q== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538440134" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.45.202]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Nov 2020 02:27:46 -0800 Date: Tue, 3 Nov 2020 10:27:41 +0000 From: Bruce Richardson To: David Marchand Cc: Thomas Monjalon , dev , Guy Kaneti , Luca Boccassi , Rosen Xu , Andrew Rybchenko Message-ID: <20201103102741.GC1132@bricha3-MOBL.ger.corp.intel.com> References: <20201102174507.1085128-1-bruce.richardson@intel.com> <4495149.WBtOTWmHy8@thomas> <2238783.mFnA29xreC@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 03, 2020 at 10:45:37AM +0100, David Marchand wrote: > On Tue, Nov 3, 2020 at 10:19 AM David Marchand > wrote: > > > > On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > > > > > 03/11/2020 09:19, David Marchand: > > > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > > > > -name = 'octeontx2_regex' > > > > > > > > > > But it is not the same? > > > > > > > > > > The name will default to "octeontx2", which is fine. > > > > > But the fmt_name should not take this default. > > > > > I believe fmt_name should be "octeontx2_regex" as I did in my patch. > > > > > > > > fmt_name is only for maintaining config compat. > > > > This driver is new to 20.11. > > > > We can drop fmt_name too. > > > > > > If we don't set fmt_name, it defaults to "name", "octeontx2" here. > > > What is the consequence in compat definitions? > > > > Ok, got it, the problem is when we disable the net/octeontx2 driver. > Your patch correctly sets a RTE_LIBRTE_OCTEONTX2_REGEX_PMD compat > option that is unused but that does not overwrite the > RTE_LIBRTE_OCTEONTX2_PMD compat option (which indicates the presence > of the net/octeontx2 driver). > Yes, I forgot about compatibility macro settings. Given the context of this patchset, I was instead just looking at the library filesnames. I'll drop this patch from v2, and you can take Thomas' instead. /Bruce