From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 73DF1A04E7;
	Tue,  3 Nov 2020 21:49:39 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id CBBE569A4;
	Tue,  3 Nov 2020 21:49:37 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id ABC25697C
 for <dev@dpdk.org>; Tue,  3 Nov 2020 21:49:36 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id BB0F820C27C5; Tue,  3 Nov 2020 12:49:34 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BB0F820C27C5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1604436574;
 bh=ux4bovD5iRX96HveMLt9VyPrJeECRH8o8k/IdpvQxyE=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=AfzpsupMw6GXsQPvTx+HwffFA3kKGE9kLgxH2cvDojieJnHqFymxPaKm79SHNab1p
 zhk9Z9NVswYlQQvfPr9Oiclb33IHs8BEGzHi6Kbjo+ITfLxNhBdQtD1+TAYw/tvT3a
 DG1R1asT+1kh6hLinbJ6NBR+PcFU5F2lqRGHDlPs=
Date: Tue, 3 Nov 2020 12:49:34 -0800
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
 John Alexander <John.Alexander@datapath.co.uk>
Message-ID: <20201103204934.GA8866@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201029225505.30093-1-dmitry.kozliuk@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 30, 2020 at 01:55:05AM +0300, Dmitry Kozlyuk wrote:
> MSBuild XML files have to use CRLF line-endings, otherwise any change
> results in the whole file being rewritten with CRLF line-endings by
> Visual Studio. However, it's inconvenient to have such files checked-out
> with CLRF in Unix environments.
> 
> Add suggested git configuration to top-level README, so that Unix
> developers don't miss it. Remove .gitattributes, because core.autocrlf
> overrides eol= attribute. Convert line-endings of the existing files in
> the repository.
> 
> Suggested-by: John Alexander <John.Alexander@datapath.co.uk>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  README                              |   5 +
>  windows/.gitattributes              |   4 -
>  windows/virt2phys/virt2phys.sln     |  54 ++--
>  windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++--------------
>  4 files changed, 259 insertions(+), 258 deletions(-)
>  delete mode 100644 windows/.gitattributes
> 
Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>