From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 57E03A04E7;
	Wed,  4 Nov 2020 09:06:35 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3A385C7F4;
	Wed,  4 Nov 2020 09:06:34 +0100 (CET)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
 [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 5E15EC6C8
 for <dev@dpdk.org>; Wed,  4 Nov 2020 09:06:31 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id v5so1473720wmh.1
 for <dev@dpdk.org>; Wed, 04 Nov 2020 00:06:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=duZeF/kmnI0T7RGblMXKkR+e3Xn1XVWNdiazs55YEOw=;
 b=UQvmrEBW4HHGrQKZAkxmdOfoJpiagK5OqiaLxyBy2yOmYn8CbwJBWR87qlv8DvCuRo
 49McWlGcb0+pXbUiBgEydGoeOLZke0u2XdLAKqOdKrPt75FZYqvEclACSmwF0hem9ail
 qAtBNggNwFoA4r9k3Dw8P4nEJt+BuZ89x9I3KqjLhmdL4KNp0YJs0nwPOBt53H86ysp5
 3eOyGU4GVhg10kY0RTm0VEHsd1dsYR7RLunH7RRFYLrPU2haiA9Uxhl4LKmrsy7Qw2A1
 ptRP51P4uBysO2YllJ0bf+zJdrpwaOtLRbDZRt/ilxZObGIceYwbc7v4Lse7cVzErxeB
 VphA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to:user-agent;
 bh=duZeF/kmnI0T7RGblMXKkR+e3Xn1XVWNdiazs55YEOw=;
 b=TT3j816TmxTBQSSXzlNUeb42JSLxyXWtIfRGOE4iWMu/d5lsxF6YRCrvFPkyfK9gby
 vufAQqajMPhllZfCuJwEKSwqO3vwatzbWjXkdRflvFQvjzO9aRr3u5zoR6sxPQ+Y8jEz
 mqoa5FYjY7fI5MZiY0RfAPhBSlGWpiadH4I/UowOBxzJ3TlzsQhCN0aX8nwfEXjuG8FG
 XJqaB459uR4nuAHrtdWEXuz883Z6rqlq2ljibG8M3pjznqsNnrZxNTDySBxAhuBZTPfX
 jUT0u+xwcDZZhmTzu5c+249AOgNqo0SwEI11BATSccpXVgOYxr0YSufO1evVqXrnVXfX
 HQKA==
X-Gm-Message-State: AOAM531XbPPn9PKh0Cd9ps7HAOGhKdglnlvMvob29/iWjL/XqvoAmpUN
 DgpOreqzMjE1qW7b+wRISG/oHQ==
X-Google-Smtp-Source: ABdhPJyb1CfL2tQ0ll++T4zBHvyRdzUihlhUvCdVjOd95jWIzdKH0kr/qCt4RrrWJmXXy1aGJP2r0Q==
X-Received: by 2002:a1c:497:: with SMTP id 145mr3220670wme.127.1604477191040; 
 Wed, 04 Nov 2020 00:06:31 -0800 (PST)
Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id b4sm1437120wro.57.2020.11.04.00.06.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 04 Nov 2020 00:06:30 -0800 (PST)
Date: Wed, 4 Nov 2020 09:06:29 +0100
From: Robin Jarry <robin.jarry@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
 Neil Horman <nhorman@tuxdriver.com>, Rosen Xu <rosen.xu@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Luca Boccassi <bluca@debian.org>
Message-ID: <20201104080629.s45zq57ivywr6pyz@6wind.com>
References: <20201103183906.8088-1-david.marchand@redhat.com>
 <20201103192750.zr6gh3oz3wjnbeys@6wind.com>
 <CAJFAV8wSkJB+D5a1yNjze39pJFUt+A5TTbCkZb0F6-ehNondGg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8wSkJB+D5a1yNjze39pJFUt+A5TTbCkZb0F6-ehNondGg@mail.gmail.com>
User-Agent: NeoMutt/20180716
Subject: Re: [dpdk-dev] [PATCH] usertools: fix pmdinfo parsing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2020-11-03, David Marchand:
> Less ugly with a regular expression?
> 
> if re.match(r"^librte_(baseband|compress|crypto|event|net|raw|regex|vdpa)_",
>             force_unicode(tag.needed)):

No, that's worse :D

As Stephen said, maybe it would be more readable if the list of
supported classes were in a constant somewhere.

  DRIVER_CLASSES = (
      'baseband',
      'compress',
      'crypto',
      'event',
      'net',
      'raw,
      'regex',
      'vdpa',
  )

-- 
Robin