From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAC6DA04E7; Wed, 4 Nov 2020 10:21:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A128AC864; Wed, 4 Nov 2020 10:21:14 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E6657C860 for ; Wed, 4 Nov 2020 10:21:11 +0100 (CET) IronPort-SDR: U2Tj8PDppITTcwD0svgoddqwDC9fcN8IdwK/R4Qr5KYJgY70Wx9rQAFXaXZONzt6f7ApMfrA3L nwvbDdbNuKfA== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="165683572" X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="165683572" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 01:21:11 -0800 IronPort-SDR: ln5udVJRi7T9nwUup6PQ23cI9hRs3+sgZg86VXCJXqXUn0IAOC7E9/h9kM1sT3m2XC+80qT941 sP/fgNsVDR+w== X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="538844064" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.46.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Nov 2020 01:21:09 -0800 Date: Wed, 4 Nov 2020 09:21:05 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20201104092105.GA58@bricha3-MOBL.ger.corp.intel.com> References: <20200906013133.26360-2-stephen@networkplumber.org> <20201104065304.26886-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104065304.26886-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH v2] cpu_layout: refactor to meet python standards X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 03, 2020 at 10:53:04PM -0800, Stephen Hemminger wrote: > Rearrange code to make it pass python lint totally clean! This includes > add a main function, docstring, and some variable name changes. > > Signed-off-by: Stephen Hemminger --- v2 - > rebase to current main > > usertools/cpu_layout.py | 143 ++++++++++++++++++++++++---------------- 1 > file changed, 85 insertions(+), 58 deletions(-) > Hi Stephen, Thanks for looking at this, but I honestly query the value of this scale of rework, since we take a 58 line linear script and increase it to an 85 line script with multiple functions being called. Rather than trying for full lint cleanliness, I think we'd be better to keep it simple and just aim for pep8/pycodestyle cleanliness. This shows only two small things to fix and saves massive rework. $ pycodestyle cpu_layout.py cpu_layout.py:18:5: E722 do not use bare 'except' cpu_layout.py:62:14: E231 missing whitespace after ',' Regards, /Bruce