From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, robin.jarry@6wind.com, stephen@networkplumber.org,
olivier.matz@6wind.com, Neil Horman <nhorman@tuxdriver.com>,
Rosen Xu <rosen.xu@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing
Date: Wed, 4 Nov 2020 10:32:49 +0000 [thread overview]
Message-ID: <20201104103249.GD58@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201104094033.29674-1-david.marchand@redhat.com>
On Wed, Nov 04, 2020 at 10:40:33AM +0100, David Marchand wrote:
> This script inspects an ELF file (binary or shared library) and its
> linked dependencies by following DT_NEEDED tags.
> So far a simple librte_pmd prefix was used as a filter.
> Now that we changed the driver library names, update this heuristic with
> an explicit list of all driver classes.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Robin Jarry <robin.jarry@6wind.com>
> ---
> Changelog since v1:
> - moved driver classes list as a class variable and did some cosmetic
> change for readibility,
> - used dpdk_driver_classes variable name in the hope that someone changing
> meson will catch this script too,
Good idea, but probably not enough. I think adding a comment to the
meson.build file to update this as well would be good.
/Bruce
next prev parent reply other threads:[~2020-11-04 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 18:39 [dpdk-dev] [PATCH] " David Marchand
2020-11-03 19:27 ` Robin Jarry
2020-11-03 20:20 ` David Marchand
2020-11-03 23:54 ` Stephen Hemminger
2020-11-04 8:04 ` Olivier Matz
2020-11-04 8:06 ` Robin Jarry
2020-11-04 9:40 ` [dpdk-dev] [PATCH v2] " David Marchand
2020-11-04 10:32 ` Bruce Richardson [this message]
2020-11-04 10:42 ` David Marchand
2020-11-05 11:46 ` Xu, Rosen
2020-11-12 13:28 ` David Marchand
2020-11-04 15:57 ` [dpdk-dev] [PATCH v3] " David Marchand
2020-11-04 16:35 ` Bruce Richardson
2020-11-04 16:48 ` David Marchand
2020-11-05 11:49 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104103249.GD58@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=robin.jarry@6wind.com \
--cc=rosen.xu@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).