From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3F7AA04B1; Wed, 4 Nov 2020 11:33:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07A6EC8C8; Wed, 4 Nov 2020 11:33:01 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9718BC8C4 for ; Wed, 4 Nov 2020 11:32:58 +0100 (CET) IronPort-SDR: kd6uKHoXn2PJIJU8wdbWFcYBHjxl4a2E+zwWYPfNlqUrbYTgGCNTiessioiRBDJXVVR8/T6MN4 NVa2XDRYAPpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="165690418" X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="165690418" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 02:32:56 -0800 IronPort-SDR: dt0I43tkxbg27S/4iH+X1ivnI5ZOvM766whBlwczbTeSaaZdxeXInG0OSsptTQpPA3SWIk9uDC VZ7qnSUfhkqA== X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="538866716" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.46.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Nov 2020 02:32:53 -0800 Date: Wed, 4 Nov 2020 10:32:49 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, robin.jarry@6wind.com, stephen@networkplumber.org, olivier.matz@6wind.com, Neil Horman , Rosen Xu , Andrew Rybchenko , Luca Boccassi Message-ID: <20201104103249.GD58@bricha3-MOBL.ger.corp.intel.com> References: <20201103183906.8088-1-david.marchand@redhat.com> <20201104094033.29674-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104094033.29674-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 04, 2020 at 10:40:33AM +0100, David Marchand wrote: > This script inspects an ELF file (binary or shared library) and its > linked dependencies by following DT_NEEDED tags. > So far a simple librte_pmd prefix was used as a filter. > Now that we changed the driver library names, update this heuristic with > an explicit list of all driver classes. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: David Marchand > Acked-by: Robin Jarry > --- > Changelog since v1: > - moved driver classes list as a class variable and did some cosmetic > change for readibility, > - used dpdk_driver_classes variable name in the hope that someone changing > meson will catch this script too, Good idea, but probably not enough. I think adding a comment to the meson.build file to update this as well would be good. /Bruce