From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 205C4A04B1; Thu, 5 Nov 2020 12:50:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05AACBE6F; Thu, 5 Nov 2020 12:50:06 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 01273BC5E for ; Thu, 5 Nov 2020 12:50:04 +0100 (CET) IronPort-SDR: eeyV1f5n6JyutkVxgzGbgKQP5/Lz1baVm0VCRkCj/0zei3h9ffIva2qQZBM+UJ0hfoPcP26cX3 9oXOcPtK2ZDA== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="169511161" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="169511161" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 03:50:02 -0800 IronPort-SDR: RhxHUch0jkW0TenTczGLllsENDG2wnbZm0CZ5iGvpHCCRO9UfswRKYgcagEQKtke85h2h0wkWQ IxTnQrPEEVQQ== X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="539368400" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.177.138]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Nov 2020 03:49:58 -0800 Date: Thu, 5 Nov 2020 11:49:53 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Robin Jarry , Stephen Hemminger , Olivier Matz , Neil Horman , Rosen Xu , Andrew Rybchenko , Luca Boccassi Message-ID: <20201105114953.GB776@bricha3-MOBL.ger.corp.intel.com> References: <20201103183906.8088-1-david.marchand@redhat.com> <20201104155721.21627-1-david.marchand@redhat.com> <20201104163546.GA65@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 04, 2020 at 05:48:27PM +0100, David Marchand wrote: > On Wed, Nov 4, 2020 at 5:36 PM Bruce Richardson > wrote: > > > > On Wed, Nov 04, 2020 at 04:57:21PM +0100, David Marchand wrote: > > > This script inspects an ELF file (binary or shared library) and its > > > linked dependencies by following DT_NEEDED tags. > > > So far a simple librte_pmd prefix was used as a filter to only parse > > > DPDK drivers dependencies. > > > While the reason is not clear from the commitlog of the patch that > > > introduced this filter, it was probably added for performance reasons, > > > since going through all dependencies can be quite long. > > > Testing with a DPDK built before the driver name changes: > > > - running the script takes ~0.3s with the filter, > > > - running the script takes ~9s without the filter, > > > > > > Now that we changed the driver library names, it becomes more difficult > > > to identify only DPDK drivers, but we can just filter on the librte_ > > > prefix to identify DPDK libraries: the script later checks for the > > > PMD_INFO_STRING string in .rodata and it is enough to differentiate the > > > DPDK drivers from the other DPDK libraries. > > > A debug message was logged for each inspected file, it gives no useful > > > information and is removed. > > > > > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > > > > > Signed-off-by: David Marchand > > > Acked-by: Robin Jarry > > > --- > > > Changelog since v2: > > > - revisited the issue and simplified to only filter on librte_ prefix, > > > > > > > Given you provided some original perf numbers of 0.3 vs 9 seconds above, > > rather than leave us all in suspense :-), can you perhaps provide the > > numbers for this version too. > > Ah ah, yes, thought I had put it. > I have values in the 0.40/0.50s range. > Sounds good. Acked-by: Bruce Richardson