From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7128EA04B1; Thu, 5 Nov 2020 14:17:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 70868BE99; Thu, 5 Nov 2020 14:17:50 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E32DEBE89 for ; Thu, 5 Nov 2020 14:17:48 +0100 (CET) IronPort-SDR: f5odS90GI8FuvrpiQOa4Q8jyjLDf7JdB9/fR/p9NQOUzbQgc9Hgs7+M7dTGt6Jfio8jDuO3n96 zg5vILOFrjvw== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="169487907" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="169487907" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 05:17:46 -0800 IronPort-SDR: 19iKriJjgF6phSyqLJV9GybHhPU7DDaFiP3I2jMCByQ0t2DaR3ynBOXMxkbADTFTdTvxRO9RwZ 53sYQTFi2Mlw== X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="529419382" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.177.138]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Nov 2020 05:17:42 -0800 Date: Thu, 5 Nov 2020 13:17:37 +0000 From: Bruce Richardson To: Gregory Etelson Cc: dev@dpdk.org, bluca@debian.org, christian.ehrhardt@canonical.com, david.marchand@redhat.com, ktraynor@redhat.com, matan@nvidia.com, rasland@nvidia.com, thomas@monjalon.net Message-ID: <20201105131737.GC776@bricha3-MOBL.ger.corp.intel.com> References: <20201029091638.26646-1-getelson@nvidia.com> <20201105123704.15791-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201105123704.15791-1-getelson@nvidia.com> Subject: Re: [dpdk-dev] [PATCH v4] build: add pkg-config validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 05, 2020 at 02:37:03PM +0200, Gregory Etelson wrote: > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. > Inaccurate build parameters, produced by pkg-config from DPDK .pc > files could fail application build or cause unpredicted results > during application runtime. > > This patch validates host pkg-config utility and notifies about > known issues. > > Signed-off-by: Gregory Etelson > --- You can keep my ack from previous version. Acked-by: Bruce Richardson One small note is that I don't believe the 'exit $?' line at the end of the script is necessary, that is default shell behaviour. However, it probably doesn't hurt to have it explicitly there. > buildtools/pkg-config/meson.build | 11 ++++++++ > buildtools/pkg-config/pkgconfig-validate.sh | 29 +++++++++++++++++++++ > doc/guides/linux_gsg/sys_reqs.rst | 5 ++++ > 3 files changed, 45 insertions(+) > create mode 100755 buildtools/pkg-config/pkgconfig-validate.sh > > diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build > index 5f19304289..4f907d7638 100644 > --- a/buildtools/pkg-config/meson.build > +++ b/buildtools/pkg-config/meson.build > @@ -53,3 +53,14 @@ This is required for a number of static inline functions in the public headers.' > # For static linking with dependencies as shared libraries, > # the internal static libraries must be flagged explicitly. > run_command(py3, 'set-static-linker-flags.py', check: true) > + > +pkgconf = find_program('pkg-config', 'pkgconf', required: false) > +if (pkgconf.found()) > + cmd = run_command('./pkgconfig-validate.sh', pkgconf.path(), > + check:false) > + if cmd.returncode() != 0 > + version = run_command(pkgconf, '--version') > + warning('invalid pkg-config version @0@'.format( > + version.stdout().strip())) > + endif > +endif > diff --git a/buildtools/pkg-config/pkgconfig-validate.sh b/buildtools/pkg-config/pkgconfig-validate.sh > new file mode 100755 > index 0000000000..f5479f999f > --- /dev/null > +++ b/buildtools/pkg-config/pkgconfig-validate.sh > @@ -0,0 +1,29 @@ > +#! /bin/sh > +# SPDX-License-Identifier: BSD-3-Clause > + > +if [ "$#" -ne 1 ]; then > + echo "$0: no pkg-config parameter" > + exit 1 > +fi > +PKGCONF="$1" > + > +# if pkgconf could not locate libdpdk.pc from existing PKG_CONFIG_PATH > +# check meson template instead > +# take the first located file > +pc_file=$(find "$MESON_BUILD_ROOT" -type f -name 'libdpdk.pc' -print -quit) > +if [ ! -f "$pc_file" ]; then > + echo "$0: cannot locate libdpdk.pc" > + exit 1 > +fi > +pc_dir=$(dirname "$pc_file") > +PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:$pc_dir" > + > +# Statically linked private DPDK objects of form > +# -l:file.a must be positioned between --whole-archive … --no-whole-archive > +# linker parameters. > +# Old pkg-config versions misplace --no-whole-archive parameter and put it > +# next to --whole-archive. > +PKG_CONFIG_PATH="$PKG_CONFIG_PATH" \ > +"$PKGCONF" --libs --static libdpdk | \ > +grep -q 'whole-archive.*l:lib.*no-whole-archive' > +exit "$?" > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > index 6ecdc04aa9..b67da05e13 100644 > --- a/doc/guides/linux_gsg/sys_reqs.rst > +++ b/doc/guides/linux_gsg/sys_reqs.rst > @@ -60,6 +60,11 @@ Compilation of the DPDK > > * Linux kernel headers or sources required to build kernel modules. > > + > +**Known Issues:** > + > +* pkg-config v0.27 supplied with RHEL-7 does not process correctly libdpdk.pc Libs.private section. > + > .. note:: > > Please ensure that the latest patches are applied to third party libraries > -- > 2.28.0 >