From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4629A04DD; Thu, 5 Nov 2020 14:36:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 475C2C7EA; Thu, 5 Nov 2020 14:36:16 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 323E9BE9B for ; Thu, 5 Nov 2020 14:36:14 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id h22so1649291wmb.0 for ; Thu, 05 Nov 2020 05:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=+6oOe+3pVK+GkcFzyPs/Pj27uz1Ki0RsJSbUQaHCSRg=; b=KmA0Be8dmf+Y3BOS1fgMHpJ8snBE1ldBhHdUe7w9q9nArfHDGaiL4VT28kCINZr5gU 4P/xe1SBfdtNt76NGf6tDU4SLwTqJB2zVFmsyHCc8mtjB/RMr7fM/76SFDAdoSY7cTAd tTmZFzyRVkym2DnifIU8OI7uYlJw7WGwc0G9iyDT5CvFiUMunW63yHMfeclWUsyTf9U4 WyLIYXjkpgxCKNKZB3uaAyARj6QjJamjeuX7WBtc8kaoIDnjNHVR7G7rB7sW6Dg8xH7B 8uqTq3klu0fb3FtcV1MjuWPPSZh894HpRJqE6A8Ga97NSdd66jtdfJgUb3BzTe11MhJO JtwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=+6oOe+3pVK+GkcFzyPs/Pj27uz1Ki0RsJSbUQaHCSRg=; b=XJ2pkv6TJB0igv70sBVZYNkALsxMW4c/BeEZobijgrAJPHQMrkyrrFMiEpWTNSFIE0 NXkY7BpMDk3QaiJlq8EkLCmb/Va46dsLFnBMGadePxb+Ckmix2Ab7ajxfcZpZ5gm9r+j 3ZTNLGjo3LmIlzqKZoQAmZgpIujfeFp6uj8VT5l3+ZX1xAAn7fXGILurfvbwmKo1OGG+ 2bPlkq/vhPwc/WfNgaugD8+NGhbsSbzNthqvyt4L2HYyWYQP4GvwwbABNC8+Xl5j2SlQ Sb5Pj5iTPdJvTaUOzPrnOv9NTagOhFUXFAA1i1SUfb3GpR6s24MhHkaeofvjC2XIU5/m m2gQ== X-Gm-Message-State: AOAM533h5iHAbzvkZRaJTFuR2U0uie6vqWkzYTLaH1GuZffM7MSL7HzY ANO2735lJ1DDaQc76qNfkCrJmblt5HXDnqJp X-Google-Smtp-Source: ABdhPJyyNjWM6ftYehStvHXhMUgGb7/ysC8uKuFXeMsOuVlQ21JXrsyCLE0I+74+8odVwBuJvzzxrg== X-Received: by 2002:a7b:c309:: with SMTP id k9mr2651829wmj.125.1604583372831; Thu, 05 Nov 2020 05:36:12 -0800 (PST) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id g66sm2813563wmg.37.2020.11.05.05.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 05:36:12 -0800 (PST) Date: Thu, 5 Nov 2020 14:36:11 +0100 From: Olivier Matz To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20201105133611.GU1898@platinum> References: <20200916081747.124520-2-mb@smartsharesystems.com> <20201026144201.54899-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201026144201.54899-1-mb@smartsharesystems.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v4] mbuf: minor cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 26, 2020 at 03:42:01PM +0100, Morten Brørup wrote: > The mbuf header files had some commenting style errors that affected the > API documentation. > Also, the RTE_ prefix was missing on a macro and a definition. > > Note: This patch does not touch the offload and attachment flags that are > also missing the RTE_ prefix. > > Changes only affecting documentation: > * Removed the MBUF_INVALID_PORT definition from rte_mbuf.h; it is > already defined in rte_mbuf_core.h. > This removal also reestablished the description of the > rte_pktmbuf_reset() function. > * Corrected the comment related to RTE_MBUF_MAX_NB_SEGS. > * Corrected the comment related to PKT_TX_QINQ_PKT. > > Changes regarding missing RTE_ prefix: > * Converted the MBUF_RAW_ALLOC_CHECK() macro to an > __rte_mbuf_raw_sanity_check() inline function. > Added backwards compatible macro with the original name. > * Renamed the MBUF_INVALID_PORT definition to RTE_MBUF_PORT_INVALID. > Added backwards compatible definition with the original name. > > v2: > * Use RTE_MBUF_PORT_INVALID instead of MBUF_INVALID_PORT in rte_mbuf.c. > > v3: > * The functions/macros used in __rte_mbuf_raw_sanity_check() require > RTE_ENABLE_ASSERT or RTE_LIBRTE_MBUF_DEBUG, or they don't use the mbuf > parameter, which generates a compiler waning. So mark the mbuf parameter > __rte_unused if none of them are defined. > > v4: > * Removed compile time variants of __rte_mbuf_raw_sanity_check(); keeping > the one variant where the mbuf parameter is marked __rte_unused. > * Reflect in the __rte_mbuf_raw_sanity_check() description headline that > it is for debug mode. > * Improved the description of RTE_MBUF_PORT_INVALID. > * Updated sfc driver to use __rte_mbuf_raw_sanity_check() instead of > MBUF_RAW_ALLOC_CHECK(). > > Signed-off-by: Morten Brørup Acked-by: Olivier Matz Thanks!