* [dpdk-dev] [PATCH] usertools/cpu_layout: fix code to be pep8 style compliant
@ 2020-11-06 12:40 Ciara Power
2020-11-13 14:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ciara Power @ 2020-11-06 12:40 UTC (permalink / raw)
To: dev
Cc: stephen, bruce.richardson, Ciara Power, andriy.berestovskyy,
thomas, stable
The pycodestyle tool flagged the following issues, which are now fixed.
$ pycodestyle cpu_layout.py
cpu_layout.py:18:5: E722 do not use bare 'except'
cpu_layout.py:62:14: E231 missing whitespace after ','
Fixes: deb87e6777c0 ("usertools: use sysfs for CPU layout")
Fixes: c9208f1dc967 ("usertools: fix CPU layout with python 3")
Cc: andriy.berestovskyy@caviumnetworks.com
Cc: thomas@monjalon.net
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
usertools/cpu_layout.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py
index cc39638213..891b9238fa 100755
--- a/usertools/cpu_layout.py
+++ b/usertools/cpu_layout.py
@@ -15,8 +15,6 @@
fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
except IOError:
continue
- except:
- break
core = int(fd.read())
fd.close()
fd = open("{}/cpu{}/topology/physical_package_id".format(base_path, cpu))
@@ -59,7 +57,7 @@
for c in cores:
output = "Core %s" % str(c).ljust(max_core_id_len)
for s in sockets:
- if (s,c) in core_map:
+ if (s, c) in core_map:
output += " " + str(core_map[(s, c)]).ljust(max_core_map_len)
else:
output += " " * (max_core_map_len + 1)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] usertools/cpu_layout: fix code to be pep8 style compliant
2020-11-06 12:40 [dpdk-dev] [PATCH] usertools/cpu_layout: fix code to be pep8 style compliant Ciara Power
@ 2020-11-13 14:41 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-11-13 14:41 UTC (permalink / raw)
To: Ciara Power; +Cc: dev, stable, stephen, bruce.richardson, andriy.berestovskyy
06/11/2020 13:40, Ciara Power:
> The pycodestyle tool flagged the following issues, which are now fixed.
>
> $ pycodestyle cpu_layout.py
> cpu_layout.py:18:5: E722 do not use bare 'except'
> cpu_layout.py:62:14: E231 missing whitespace after ','
>
> Fixes: deb87e6777c0 ("usertools: use sysfs for CPU layout")
> Fixes: c9208f1dc967 ("usertools: fix CPU layout with python 3")
> Cc: andriy.berestovskyy@caviumnetworks.com
> Cc: thomas@monjalon.net
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-13 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 12:40 [dpdk-dev] [PATCH] usertools/cpu_layout: fix code to be pep8 style compliant Ciara Power
2020-11-13 14:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).