From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v3 1/1] devtools: test 32-bit build
Date: Fri, 6 Nov 2020 17:01:05 +0000 [thread overview]
Message-ID: <20201106170105.GA286@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201106165611.232288-1-thomas@monjalon.net>
On Fri, Nov 06, 2020 at 05:56:10PM +0100, Thomas Monjalon wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
>
> It's reasonably common for patches to have issues when built on 32-bits, so
> to prevent this, we can add a 32-bit build (if supported) to the
> "test-meson-builds.sh" script. The tricky bit is using a valid
> PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that
> should point to in order to get a successful build.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v3: unset override
> move and rename override
> split command in check_cc_flags
> use check_cc_flags for x86 default build
> v2: added separate flag checking function
> added override of the DPDK_TARGET value
> added /usr/lib32 as possible 32-bit libdir
> ---
> devtools/test-meson-builds.sh | 32 +++++++++++++++++++++++++++++---
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index a87de635a2..ac76c2184b 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -43,6 +43,12 @@ default_cppflags=$CPPFLAGS
> default_cflags=$CFLAGS
> default_ldflags=$LDFLAGS
>
> +check_cc_flags () # <flag to check> <flag2> ...
> +{
> + echo 'int main(void) { return 0; }' |
> + cc $@ -x c - -o /dev/null 2> /dev/null
Minor nit, as a continuation of the previous line, I think this should be
further indented.
Otherwise all looks good to me. Thanks for the updated changes.
/Bruce
next prev parent reply other threads:[~2020-11-06 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 11:07 [dpdk-dev] [PATCH] test-meson-builds: add a " Bruce Richardson
2020-11-05 11:13 ` Thomas Monjalon
2020-11-05 11:21 ` Bruce Richardson
2020-11-05 12:56 ` Thomas Monjalon
2020-11-05 17:19 ` Bruce Richardson
2020-11-05 17:21 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2020-11-06 12:40 ` Thomas Monjalon
2020-11-06 14:08 ` Bruce Richardson
2020-11-06 16:56 ` [dpdk-dev] [PATCH v3 1/1] devtools: test " Thomas Monjalon
2020-11-06 17:01 ` Bruce Richardson [this message]
2020-11-06 17:11 ` Thomas Monjalon
2020-11-06 17:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106170105.GA286@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).