From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BB6DA04B5; Fri, 6 Nov 2020 18:01:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4738DED; Fri, 6 Nov 2020 18:01:33 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 879F62AB for ; Fri, 6 Nov 2020 18:01:31 +0100 (CET) IronPort-SDR: 1acouYrfuAK/jF9gWZHLKw1kJ7Z0sxFZ26cIuBHXtReeTQkfZ9TFMDw1zk15YDnVpdavBB2M2A 4mG/XVmSkH+w== X-IronPort-AV: E=McAfee;i="6000,8403,9797"; a="149420921" X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="149420921" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 09:01:11 -0800 IronPort-SDR: EmvEXUypBkBN05ozOr1xb9QBsm2tJ3pwBG++DQp5dQzJ0MHIj1uEuvOSAnrwAVnDA45cCD+cGQ GQFfCNI4fjPQ== X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="539908102" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.88]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Nov 2020 09:01:09 -0800 Date: Fri, 6 Nov 2020 17:01:05 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com Message-ID: <20201106170105.GA286@bricha3-MOBL.ger.corp.intel.com> References: <20201105110728.220957-1-bruce.richardson@intel.com> <20201106165611.232288-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106165611.232288-1-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v3 1/1] devtools: test 32-bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 06, 2020 at 05:56:10PM +0100, Thomas Monjalon wrote: > From: Bruce Richardson > > It's reasonably common for patches to have issues when built on 32-bits, so > to prevent this, we can add a 32-bit build (if supported) to the > "test-meson-builds.sh" script. The tricky bit is using a valid > PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that > should point to in order to get a successful build. > > Signed-off-by: Bruce Richardson > Signed-off-by: Thomas Monjalon > --- > v3: unset override > move and rename override > split command in check_cc_flags > use check_cc_flags for x86 default build > v2: added separate flag checking function > added override of the DPDK_TARGET value > added /usr/lib32 as possible 32-bit libdir > --- > devtools/test-meson-builds.sh | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index a87de635a2..ac76c2184b 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -43,6 +43,12 @@ default_cppflags=$CPPFLAGS > default_cflags=$CFLAGS > default_ldflags=$LDFLAGS > > +check_cc_flags () # ... > +{ > + echo 'int main(void) { return 0; }' | > + cc $@ -x c - -o /dev/null 2> /dev/null Minor nit, as a continuation of the previous line, I think this should be further indented. Otherwise all looks good to me. Thanks for the updated changes. /Bruce