From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F51CA0527; Mon, 9 Nov 2020 16:54:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 148EF6004; Mon, 9 Nov 2020 16:54:52 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 6AA8F5F13 for ; Mon, 9 Nov 2020 16:54:50 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id z3so8529065pfb.10 for ; Mon, 09 Nov 2020 07:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PATyVNLcFRYpyiONEZrFg/PzqeDJaEUtFtNDy2E2L0Q=; b=FjwFu8g5mfgKcOiWk7FFy13OCcNHYahcR9j6H2uyTuky9mWoUJf4tmDXLTHC2zEcLX dsSDJ8IdbFzoC9O7OCc/H1QBMLzRCBGKezyQreGXp8IJf2Dm4P4jqxXObFYe7VHXW6gk eM8mqB7uPRGupXjxZCe5EBdm2NpbkKb8e9uWoiR8ojOq0hOXvz+nkx98tYVPQBpBnDJG MRORe/Fsumk3w8TCPXa5FJWRzqoed/0H4cYfR5au/pzgwv6Lv2jyCgfHs6mNEZCfqwc7 NpNHtVz6ld3vsZkQ1MfCrjkMJ2glbfZoQGcj66yDwebdFsoVYVOyB1uyEAU+bPQzlFgu chHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PATyVNLcFRYpyiONEZrFg/PzqeDJaEUtFtNDy2E2L0Q=; b=Mi29u5zybJ+Sn6rsypozvoFJkjmqwWjeH7VevgmqWrCxCJVkHyNl257OHj8d2eft81 JHqb16jnNP4JcOp8h+EYa2e7GHUBOMpwoNB/8h83SBO5XfeOeCCUyHz9X15F+NnljffQ lw1WbYfOijwU9yuK9bN8TA7bz+fGrJZ0Rpsp84w0nD6SphL0iGpYUqpDf6mn0LHWA74h yCg7y0raM+sBQ3UqopZwYoXJJr8WPYg/0vpXlCv7l/TQ58ZFHOnEnPIgFhwaeyM+3gmr VpARNKhf9K6+AlRnaIwCxSrcAkOdt3YgKb7/YPg2RUFkhX1eOD3ajTKy6MaZ8TYaf5vK d4rw== X-Gm-Message-State: AOAM530zDD8KYNx35j+yBlUBzEB3N5V+09wu9q2QGiESZ7a8yBxPOWQp yh2WoRJ8SPT6bI3UqvJUpmgKEQ== X-Google-Smtp-Source: ABdhPJzcaIc0Cff6nMTd9sHbXSzsgKJbQ2YUdmPMNjQh3sC9/1+IEKVx4I+tKX8MkHEzvkdacDCEOA== X-Received: by 2002:a05:6a00:158b:b029:18b:fd84:956d with SMTP id u11-20020a056a00158bb029018bfd84956dmr6022192pfk.22.1604937288488; Mon, 09 Nov 2020 07:54:48 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i11sm11312227pfd.211.2020.11.09.07.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 07:54:48 -0800 (PST) Date: Mon, 9 Nov 2020 07:54:40 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, Luca Boccassi , Gaetan Rivet Message-ID: <20201109075440.44130509@hermes.local> In-Reply-To: <20201109134931.GG831@bricha3-MOBL.ger.corp.intel.com> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> <20201109134931.GG831@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 9 Nov 2020 13:49:31 +0000 Bruce Richardson wrote: > On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote: > > This patch renames the enum values in the EAL include files. > > As a backward compatible temporary migration tool, define > > a replacement mapping for old values. > > > > The old names relating to blacklist and whitelist are replaced > > by block list and allow list, but applications may be using the > > older compatibility macros. To help with conversion to new names > > cause a message when the compatibility names are used. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Luca Boccassi > > Acked-by: Gaetan Rivet > > --- > > lib/librte_eal/common/eal_common_devargs.c | 14 +++++++------- > > lib/librte_eal/include/rte_bus.h | 10 ++++++++-- > > lib/librte_eal/include/rte_dev.h | 10 ++++++++-- > > lib/librte_eal/include/rte_devargs.h | 10 ++++++++-- > > 4 files changed, 31 insertions(+), 13 deletions(-) > > > > > +/* Backwards compatibility will be removed later */ > > +#define RTE_DEVTYPE_WHITELISTED_PCI \ > > + RTE_DEPRECATED(RTE_DEVTYPE_WHITELISTED_PCI) RTE_DEVTYPE_ALLOWED > > +#define RTE_DEVTYPE_BLACKLISTED_PCI \ > > + RTE_DEPRECATED(RTE_DEVTYPE_BLACKLISTED_PCI) RTE_DEVTYPE_BLOCKED > > + > > This patch causes build failures which persist until patch 3, because of > these deprecations. I think you need to define the backward-compatibility > macros here, but only mark them deprecated at the end of the set. > > /Bruce Is building without warnings in every step that important? The previous patch series for master/slave had the same effect