From: "Gaëtan Rivet" <grive@u256.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>
Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing
Date: Mon, 9 Nov 2020 14:36:49 +0100 [thread overview]
Message-ID: <20201109130859.ixz6pj57wwzfve3s@u256.net> (raw)
In-Reply-To: <CAJFAV8xtCCjneYkhJ8q6m=2hRKf+a590tPTDZj8sf3r6zCev1w@mail.gmail.com>
On 09/11/20 12:58 +0100, David Marchand wrote:
> On Mon, Nov 9, 2020 at 12:32 PM Gaetan Rivet <grive@u256.net> wrote:
> > + delta = 0;
> > + if (strncmp(name, "dpaa_bus:", 9) == 0) {
> > + delta = 9;
> > + } else if (strncmp(name, "name=", 5) == 0) {
> > + delta = 5;
> > + }
> > +
> > + if (sscanf(&name[delta], "fm%u-mac%u", &i, &j) == 2) {
> > + if (i >= 2 || j >= 16)
> > + return -EINVAL;
> > + if (out != NULL) {
> > + char *out_name = out;
> > +
> > + if (rte_strscpy(out_name, &name[delta], 10) < 0)
> > + return -ENAMETOOLONG;
> > + /* Because 'i' can only be 0 or 1, fm%u is fixed size ;
> > + * mac%u needs to be checked for optional end ','.
> > + */
> > + if (out_name[9] == ',')
> > + out_name[9] = '\0';
> > }
> > + return 0;
> > + } else {
> > + return -EINVAL;
> > }
>
> Mmm, we always return from each of the previous branches?
> Then the ENODEV return after is dead code.
>
> Reading again the diff, you could probably return at the sscanf step.
> if (sscanf(&name[delta], "fm%u-mac%u", &i, &j) != 2 || i >= 2 || j >= 16)
> return -EINVAL;
>
>
Yes good point, I will refactor.
> >
> > - free(dup_name);
> > - return -EINVAL;
> > + return -ENODEV;
> > }
> >
> > #define DPAA_DEV_PATH1 "/sys/devices/platform/soc/soc:fsl,dpaa"
>
>
> --
> David Marchand
>
--
Gaëtan
next prev parent reply other threads:[~2020-11-09 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 11:31 Gaetan Rivet
2020-11-09 11:44 ` Gaëtan Rivet
2020-11-09 11:58 ` David Marchand
2020-11-09 13:36 ` Gaëtan Rivet [this message]
2020-11-09 13:37 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2021-01-15 11:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109130859.ixz6pj57wwzfve3s@u256.net \
--to=grive@u256.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).