From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C49F8A0527; Mon, 9 Nov 2020 14:49:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24D5A5B3A; Mon, 9 Nov 2020 14:49:42 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8DCBF5B30 for ; Mon, 9 Nov 2020 14:49:39 +0100 (CET) IronPort-SDR: siffefsZt8Oypm5W9epLvQYzu9pr87MgJVTLmpB5VU5DZjzujvo0dGLD+Xdpn2TNqFueonbYw8 8i8mzQyJXZ9Q== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="187751232" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="187751232" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 05:49:38 -0800 IronPort-SDR: DsSxdZQQ64yfcTYlk077ZIvKqiem0t6+VD/vVy0FzG7polvHvxZ9K42CPTquWE+UysZBbvVD4m yXffFVwulUKw== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="472983492" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.194.11]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Nov 2020 05:49:36 -0800 Date: Mon, 9 Nov 2020 13:49:31 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org, Luca Boccassi , Gaetan Rivet Message-ID: <20201109134931.GG831@bricha3-MOBL.ger.corp.intel.com> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201105223602.5965-2-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote: > This patch renames the enum values in the EAL include files. > As a backward compatible temporary migration tool, define > a replacement mapping for old values. > > The old names relating to blacklist and whitelist are replaced > by block list and allow list, but applications may be using the > older compatibility macros. To help with conversion to new names > cause a message when the compatibility names are used. > > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > Acked-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_devargs.c | 14 +++++++------- > lib/librte_eal/include/rte_bus.h | 10 ++++++++-- > lib/librte_eal/include/rte_dev.h | 10 ++++++++-- > lib/librte_eal/include/rte_devargs.h | 10 ++++++++-- > 4 files changed, 31 insertions(+), 13 deletions(-) > > +/* Backwards compatibility will be removed later */ > +#define RTE_DEVTYPE_WHITELISTED_PCI \ > + RTE_DEPRECATED(RTE_DEVTYPE_WHITELISTED_PCI) RTE_DEVTYPE_ALLOWED > +#define RTE_DEVTYPE_BLACKLISTED_PCI \ > + RTE_DEPRECATED(RTE_DEVTYPE_BLACKLISTED_PCI) RTE_DEVTYPE_BLOCKED > + This patch causes build failures which persist until patch 3, because of these deprecations. I think you need to define the backward-compatibility macros here, but only mark them deprecated at the end of the set. /Bruce ../lib/librte_eal/common/eal_common_options.c: In function ‘eal_parse_common_option’: ../lib/librte_eal/common/eal_common_options.c:1458:13: error: "RTE_DEVTYPE_BLACKLISTED_PCI" is deprecated [-Werror] 1458 | if (eal_option_device_add(RTE_DEVTYPE_BLACKLISTED_PCI, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../lib/librte_eal/common/eal_common_options.c:1468:13: error: "RTE_DEVTYPE_WHITELISTED_PCI" is deprecated [-Werror] 1468 | if (eal_option_device_add(RTE_DEVTYPE_WHITELISTED_PCI, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors